Skip to content

Commit 92000cc

Browse files
ToolboxAidToolboxAid
committed
PR_26172_OWNER_032 GitHub hygiene audit template
1 parent 706c469 commit 92000cc

7 files changed

Lines changed: 902 additions & 17 deletions

‎docs_build/dev/PROJECT_INSTRUCTIONS.md‎

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2117,6 +2117,57 @@ Rules:
21172117
- PI closeout must not imply approval to merge, close PRs, delete branches, or remove deferred work without explicit owner approval.
21182118
- If the repository is not on clean, synchronized main, PI closeout status = FAIL.
21192119

2120+
## GITHUB HYGIENE AUDIT GOVERNANCE
2121+
2122+
GitHub hygiene cleanup must begin with an audit-only pass.
2123+
2124+
Audit targets:
2125+
- open PRs
2126+
- draft PRs
2127+
- merged PR branches
2128+
- stale remote branches
2129+
- stale local branches
2130+
2131+
Recommendation-only first pass values:
2132+
- keep
2133+
- close
2134+
- delete local
2135+
- delete remote
2136+
- defer
2137+
2138+
Rules:
2139+
- Do not delete branches during the audit-only pass.
2140+
- Do not close PRs during the audit-only pass.
2141+
- Do not delete local branches without explicit owner approval.
2142+
- Do not delete remote branches without explicit owner approval.
2143+
- Do not close open or draft PRs without explicit owner approval.
2144+
- Cleanup actions must preserve EOD Workstream Closeout final-state requirements.
2145+
2146+
Command expectations for cleanup audits:
2147+
- report current branch
2148+
- report worktree status
2149+
- report local/origin sync
2150+
- list open PRs
2151+
- list draft PRs
2152+
- list local branches
2153+
- list remote branches
2154+
- identify merged branch candidates
2155+
- identify stale branch candidates
2156+
2157+
Required cleanup audit report fields:
2158+
- audit date
2159+
- repository
2160+
- final main commit, if on main
2161+
- current branch
2162+
- local/origin sync
2163+
- open PR recommendations
2164+
- draft PR recommendations
2165+
- merged PR branch recommendations
2166+
- stale remote branch recommendations
2167+
- stale local branch recommendations
2168+
- deferred cleanup items
2169+
- owner approvals required before action
2170+
21202171
## OWNER-CONTROLLED STABLE AND MERGE APPROVAL
21212172

21222173
Stable promotion and merge approval are owner-controlled.

‎docs_build/dev/ProjectInstructions/addendums/multi_team.md‎

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,57 @@ Rules:
136136
- PI closeout must not imply approval to merge, close PRs, delete branches, or remove deferred work without explicit owner approval.
137137
- If the repository is not on clean, synchronized main, PI closeout status = FAIL.
138138

139+
## GitHub Hygiene Audit Governance
140+
141+
GitHub hygiene cleanup must begin with an audit-only pass.
142+
143+
Audit targets:
144+
- open PRs
145+
- draft PRs
146+
- merged PR branches
147+
- stale remote branches
148+
- stale local branches
149+
150+
Recommendation-only first pass values:
151+
- keep
152+
- close
153+
- delete local
154+
- delete remote
155+
- defer
156+
157+
Rules:
158+
- Do not delete branches during the audit-only pass.
159+
- Do not close PRs during the audit-only pass.
160+
- Do not delete local branches without explicit owner approval.
161+
- Do not delete remote branches without explicit owner approval.
162+
- Do not close open or draft PRs without explicit owner approval.
163+
- Cleanup actions must preserve EOD Workstream Closeout final-state requirements.
164+
165+
Command expectations for cleanup audits:
166+
- report current branch
167+
- report worktree status
168+
- report local/origin sync
169+
- list open PRs
170+
- list draft PRs
171+
- list local branches
172+
- list remote branches
173+
- identify merged branch candidates
174+
- identify stale branch candidates
175+
176+
Required cleanup audit report fields:
177+
- audit date
178+
- repository
179+
- final main commit, if on main
180+
- current branch
181+
- local/origin sync
182+
- open PR recommendations
183+
- draft PR recommendations
184+
- merged PR branch recommendations
185+
- stale remote branch recommendations
186+
- stale local branch recommendations
187+
- deferred cleanup items
188+
- owner approvals required before action
189+
139190
## Conflict Note
140191

141192
Existing ProjectInstructions wording that appears to require immediate or automatic merge remains preserved for traceability.

‎docs_build/dev/reports/PR_26172_OWNER_032-github-hygiene-audit-template-instruction-compliance-checklist.md‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# Instruction Compliance Checklist
2+
3+
PR: $pr
4+
5+
- [x] Read docs_build/dev/PROJECT_INSTRUCTIONS.md.
6+
- [x] Read docs_build/dev/PROJECT_MULTI_PC.txt.
7+
- [x] Verified current branch was the approved OWNER workstream branch.
8+
- [x] Verified repository was clean/synced after PR 031 push before PR 032 edits.
9+
- [x] Verified PR TEAM token is OWNER.
10+
- [x] Verified OWNER governance scope matches TEAM ownership.
11+
- [x] Updated only scoped governance documentation and required reports.
12+
- [x] Ran git diff --check.
13+
- [x] Verified no conflicting governance wording.
14+
- [x] Verified EOD closeout remains authoritative.
15+
- [x] Verified no branch deletion or PR closing was performed.
16+
- [x] Documented skipped Playwright and samples lanes.
17+
- [x] Created required Codex reports.
18+
- [x] Created repo-structured delta ZIP under mp/.

‎docs_build/dev/reports/PR_26172_OWNER_032-github-hygiene-audit-template-manual-validation-notes.md‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# Manual Validation Notes
2+
3+
PR: $pr
4+
5+
## Checks Performed
6+
7+
- Confirmed GitHub Hygiene Audit governance was added to legacy and active ProjectInstructions governance.
8+
- Confirmed audit targets include open PRs, draft PRs, merged PR branches, stale remote branches, and stale local branches.
9+
- Confirmed recommendation-only first pass values include keep, close, delete local, delete remote, and defer.
10+
- Confirmed branch deletion and PR closure require explicit owner approval.
11+
- Confirmed command expectations and cleanup audit report fields are present.
12+
- Confirmed cleanup actions must preserve EOD Workstream Closeout final-state requirements.
13+
14+
## Manual Result
15+
16+
PASS
17+
18+
## Skipped Validation
19+
20+
- Playwright was not run because no UI or runtime behavior changed.
21+
- Samples were not run because no samples or sample-impacting runtime changed.

‎docs_build/dev/reports/PR_26172_OWNER_032-github-hygiene-audit-template.md‎

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
# PR_26172_OWNER_032-github-hygiene-audit-template
2+
3+
## Scope
4+
5+
Add GitHub hygiene audit template/process for recommendation-only cleanup review.
6+
7+
## Team Ownership
8+
9+
- TEAM token: OWNER
10+
- Ownership classification: governance / workflow governance
11+
- TEAM ownership result: PASS
12+
13+
## Files Changed
14+
15+
- docs_build/dev/PROJECT_INSTRUCTIONS.md
16+
- docs_build/dev/ProjectInstructions/addendums/multi_team.md
17+
- docs_build/dev/reports/codex_changed_files.txt
18+
- docs_build/dev/reports/codex_review.diff
19+
- docs_build/dev/reports/PR_26172_OWNER_032-github-hygiene-audit-template.md
20+
- docs_build/dev/reports/PR_26172_OWNER_032-github-hygiene-audit-template-manual-validation-notes.md
21+
- docs_build/dev/reports/PR_26172_OWNER_032-github-hygiene-audit-template-instruction-compliance-checklist.md
22+
23+
## Change Summary
24+
25+
- Added GitHub Hygiene Audit governance to require an audit-only first pass.
26+
- Defined audit targets for open PRs, draft PRs, merged PR branches, stale remote branches, and stale local branches.
27+
- Added recommendation values: keep, close, delete local, delete remote, defer.
28+
- Prohibited branch deletion and PR closure without explicit owner approval.
29+
- Added command expectations and required cleanup audit report fields.
30+
31+
## Validation
32+
33+
- git diff --check: PASS
34+
- Verified GitHub Hygiene Audit governance exists: PASS
35+
- Verified audit targets and recommendation values exist: PASS
36+
- Verified no branch deletion or PR closing without owner approval: PASS
37+
- Verified no conflicting governance wording: PASS
38+
- Verified EOD closeout remains authoritative: PASS
39+
40+
## Skipped Lanes
41+
42+
- Playwright: skipped because this is docs/governance-only.
43+
- Samples: skipped because no runtime, sample, or UI files changed.

‎docs_build/dev/reports/codex_changed_files.txt‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,13 @@
11
docs_build/dev/PROJECT_INSTRUCTIONS.md
22
docs_build/dev/ProjectInstructions/addendums/multi_team.md
3-
docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance.md
4-
docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance-manual-validation-notes.md
3+
docs_build/dev/reports/PR_26172_OWNER_030-workstream-hygiene-governance-instruction-compliance-checklist.md
4+
docs_build/dev/reports/PR_26172_OWNER_030-workstream-hygiene-governance-manual-validation-notes.md
5+
docs_build/dev/reports/PR_26172_OWNER_030-workstream-hygiene-governance.md
56
docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance-instruction-compliance-checklist.md
7+
docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance-manual-validation-notes.md
8+
docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance.md
9+
docs_build/dev/reports/PR_26172_OWNER_032-github-hygiene-audit-template-instruction-compliance-checklist.md
10+
docs_build/dev/reports/PR_26172_OWNER_032-github-hygiene-audit-template-manual-validation-notes.md
11+
docs_build/dev/reports/PR_26172_OWNER_032-github-hygiene-audit-template.md
612
docs_build/dev/reports/codex_changed_files.txt
713
docs_build/dev/reports/codex_review.diff

0 commit comments

Comments
 (0)