Uninitialized variable in OpenContain::getClosestRider

[xezon]

Object* OpenContain::getClosestRider( const Coord3D *pos )
{
	Object *closest = nullptr;
	Real closestDistance; // <--- uninitialized and maybe used when uninitialized?

	for(ContainedItemsList::const_iterator it = m_containList.begin(); it != m_containList.end(); ++it)
	{
    Object *rider = *it;

    if (rider)
    {
      Real distance = ThePartitionManager->getDistanceSquared( rider, pos, FROM_CENTER_2D );
	    if( !closest || closestDistance > distance )
	    {
		    closest = rider;
		    closestDistance = distance;
	    }
    }

  }

   return closest; //Could be null!
}

[xezon]

Greptile bot said:

The closestDistance local in getClosestRider is uninitialized and will likely produce compiler warnings on strict builds, even though runtime behavior is safe due to short-circuit evaluation

[Caball009]

Greptile is right; this is safe.

The first time this is executed: if( !closest || closestDistance > distance ),
closest must be nullptr, and after that the issue goes away because closestDistance is set to distance.

[Caball009]

Ideally, closestDistance is initialized, though.

If we set it to FLT_MAX, we could get rid of the other check:

Object* closest = nullptr;
Real closestDistance = FLT_MAX;

for (ContainedItemsList::const_iterator it = m_containList.begin(); it != m_containList.end(); ++it)
{
	if (Object* rider = *it)
	{
		const Real distance = ThePartitionManager->getDistanceSquared(rider, pos, FROM_CENTER_2D);
		if (closestDistance > distance)
		{
			closest = rider;
			closestDistance = distance;
		}
	}
}

return closest; //Could be null!