Skip to content

Commit c3ffd63

Browse files
fix: handle edge case for 1 in deficient number
1 parent 5c39e87 commit c3ffd63

2 files changed

Lines changed: 77 additions & 0 deletions

File tree

‎Maths/DeficientNumber.js‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
/**
2+
* @function isDeficientNumber
3+
* @description A deficient number is a positive integer for which the
4+
* sum of its proper divisors is less than the number itself.
5+
* For example, 9 is deficient because 1+3=4 < 9.
6+
* @param {number} n - A positive integer
7+
* @returns {boolean} - True if n is a deficient number, false otherwise
8+
* @see https://en.wikipedia.org/wiki/Deficient_number
9+
* @example isDeficientNumber(9) => true
10+
* @example isDeficientNumber(10) => false
11+
* @example isDeficientNumber(1) => true
12+
*/
13+
const isDeficientNumber = (n) => {
14+
if (!Number.isInteger(n) || n < 1) {
15+
throw new TypeError('Input must be a positive integer')
16+
}
17+
if (n === 1) return false
18+
let sum = 1
19+
for (let i = 2; i <= Math.sqrt(n); i++) {
20+
if (n % i === 0) {
21+
sum += i
22+
if (i !== n / i) sum += n / i
23+
}
24+
}
25+
return sum < n
26+
}
27+
28+
export { isDeficientNumber }

‎Maths/test/DeficientNumber.test.js‎

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
import { isDeficientNumber } from '../DeficientNumber.js'
2+
3+
describe('isDeficientNumber', () => {
4+
test('1 is NOT a deficient number', () => {
5+
expect(isDeficientNumber(1)).toBe(false)
6+
})
7+
8+
test('9 is a deficient number (1+3=4 < 9)', () => {
9+
expect(isDeficientNumber(9)).toBe(true)
10+
})
11+
12+
test('10 is a deficient number (1+2+5=8 < 10)', () => {
13+
expect(isDeficientNumber(10)).toBe(true)
14+
})
15+
16+
test('prime numbers are deficient', () => {
17+
expect(isDeficientNumber(7)).toBe(true)
18+
expect(isDeficientNumber(11)).toBe(true)
19+
expect(isDeficientNumber(13)).toBe(true)
20+
})
21+
22+
test('6 is NOT deficient (perfect number)', () => {
23+
expect(isDeficientNumber(6)).toBe(false)
24+
})
25+
26+
test('12 is NOT deficient (abundant number)', () => {
27+
expect(isDeficientNumber(12)).toBe(false)
28+
})
29+
30+
test('28 is NOT deficient (perfect number)', () => {
31+
expect(isDeficientNumber(28)).toBe(false)
32+
})
33+
34+
test('18 is NOT deficient (abundant number)', () => {
35+
expect(isDeficientNumber(18)).toBe(false)
36+
})
37+
38+
test('throws TypeError for zero', () => {
39+
expect(() => isDeficientNumber(0)).toThrow(TypeError)
40+
})
41+
42+
test('throws TypeError for negative input', () => {
43+
expect(() => isDeficientNumber(-9)).toThrow(TypeError)
44+
})
45+
46+
test('throws TypeError for float input', () => {
47+
expect(() => isDeficientNumber(9.5)).toThrow(TypeError)
48+
})
49+
})

0 commit comments

Comments
 (0)