From e2b7caf0cd2e80794cd98ab8d509fa951c927e49 Mon Sep 17 00:00:00 2001
From: Daniel Bohlin <daniel.bohlin@live.se>
Date: Sun, 26 Jul 2026 19:10:36 +0200
Subject: [PATCH] fix(pack): publish symbols as snupkg so they actually reach
 nuget.org
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

IncludeSymbols was on but SymbolPackageFormat was not set, so pack
emitted the legacy `Foo.<version>.symbols.nupkg`. That filename still
ends in `.nupkg`, so the release workflow's

    for pkg in ./artifacts/*.nupkg

loop picked it up and pushed it as a *regular* package. nuget.org
rejected it as a duplicate of the main package — same id, same version —
and the `|| true` at the end of the push line swallowed the error, so
every release went green while publishing no symbols at all.

A `.snupkg` is not matched by that glob, and `dotnet nuget push` uploads
it alongside its `.nupkg` automatically. The artifact step already
uploads the whole ./artifacts directory, so the file survives the
hand-off from the build job to the release job.

No republish is needed; this takes effect on the next release.
---
 Tharga.Toolkit.Standard/Tharga.Toolkit.Standard.csproj | 4 ++++
 Tharga.Toolkit/Tharga.Toolkit.csproj                   | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/Tharga.Toolkit.Standard/Tharga.Toolkit.Standard.csproj b/Tharga.Toolkit.Standard/Tharga.Toolkit.Standard.csproj
index 2cb5bd3..11ead32 100644
--- a/Tharga.Toolkit.Standard/Tharga.Toolkit.Standard.csproj
+++ b/Tharga.Toolkit.Standard/Tharga.Toolkit.Standard.csproj
@@ -15,6 +15,10 @@
     <PackageProjectUrl>https://github.com/Tharga/Toolkit</PackageProjectUrl>
     <PackageReadmeFile>README.md</PackageReadmeFile>
     <IncludeSymbols>true</IncludeSymbols>
+    <!-- Without this, pack emits the legacy .symbols.nupkg, whose name still ends
+         in .nupkg, so the release push loop uploads it as a regular package and
+         nuget.org rejects it as a duplicate. No symbols ever shipped. -->
+    <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <IncludeSource>true</IncludeSource>
     <PublishRepositoryUrl>true</PublishRepositoryUrl>
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
diff --git a/Tharga.Toolkit/Tharga.Toolkit.csproj b/Tharga.Toolkit/Tharga.Toolkit.csproj
index c0f0f53..c1c640b 100644
--- a/Tharga.Toolkit/Tharga.Toolkit.csproj
+++ b/Tharga.Toolkit/Tharga.Toolkit.csproj
@@ -15,6 +15,10 @@
 		<PackageProjectUrl>https://github.com/Tharga/Toolkit</PackageProjectUrl>
 		<PackageReadmeFile>README.md</PackageReadmeFile>
 		<IncludeSymbols>true</IncludeSymbols>
+		<!-- Without this, pack emits the legacy .symbols.nupkg, whose name still ends
+		     in .nupkg, so the release push loop uploads it as a regular package and
+		     nuget.org rejects it as a duplicate. No symbols ever shipped. -->
+		<SymbolPackageFormat>snupkg</SymbolPackageFormat>
 		<IncludeSource>true</IncludeSource>
 		<PublishRepositoryUrl>true</PublishRepositoryUrl>
 		<EmbedUntrackedSources>true</EmbedUntrackedSources>