feature: removing dry-run behavior, will just run incremental tests now too

Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>

Author: cmgoffena13

docs/concepts/overview.md

@@ -52,7 +52,7 @@ Bad data is worse than no data. The best way to keep bad data out of your system
 ### [Tests](./tests.md)
 SQLMesh "tests" are similar to unit tests in software development, where the unit is a single model. SQLMesh tests validate model *code* — you specify the input data and expected output, then SQLMesh runs the test and compares the expected and actual output.
 
-SQLMesh automatically runs tests for models included in a `plan` (added, modified, or restated). Plans with no such models, and `--skip-backfill` / `--dry-run` plans, skip unit tests by default. Use `--all-tests` for the full suite, `--skip-tests` to skip, or run tests on demand with the [`test` command](../reference/cli.md#test).
+SQLMesh automatically runs tests for models included in a `plan` (added, modified, or restated). Plans with no such models skip unit tests by default. Use `--all-tests` for the full suite, `--skip-tests` to skip, or run tests on demand with the [`test` command](../reference/cli.md#test).
 
 Learn more in the [testing guide](../guides/testing.md).
 

docs/concepts/tests.md

@@ -4,10 +4,6 @@ Testing allows you to protect your project from regression by continuously verif
 
 By default, `sqlmesh plan` runs unit tests only for models included in the plan (added, modified, or restated). Plans with no such models skip unit tests. Use `--all-tests` to run the full suite, or `--skip-tests` to run none.
 
-!!! important
-
-    `--skip-backfill` / `--dry-run` plans skip unit tests by default. Pass `--all-tests` if you still want the full suite to run.
-
 Similar to unit testing in software development, SQLMesh evaluates the model's logic against predefined inputs and then compares the output to expected outcomes provided as part of each test.
 
 A comprehensive suite of tests can empower data practitioners to work with confidence, as it allows them to ensure models behave as expected after changes have been applied to them.

docs/guides/models.md

@@ -162,10 +162,6 @@ Reverting to a previous model version is a quick operation since no additional w
 SQLMesh automatically validates your models in order to ensure the quality and accuracy of your data. This is done via the following:
 
 * Running unit tests for models in the plan when you execute the `plan` command (use `--all-tests` for the full suite, or `--skip-tests` to skip). This ensures changes applied to any environment are logically validated. Refer to [testing](../concepts/tests.md) for more information.
-
-    !!! important
-
-        `--skip-backfill` / `--dry-run` plans skip unit tests by default. Pass `--all-tests` if you still want tests to run.
 * Running audits whenever data is loaded to a table (either for backfill or loading on a cadence). This way you know all data present in any table has passed all defined audits. Refer to [auditing](../concepts/audits.md) for more information.
 
 SQLMesh also provides automatic validation via CI/CD by automatically creating a preview environment.

docs/guides/testing.md

@@ -14,10 +14,6 @@ As the unit tests run, SQLMesh will identify any that fail.
 
 By default, `sqlmesh plan` runs unit tests only for models included in the plan (added, modified, or restated). Plans with no such models skip unit tests. Use `--all-tests` to run the full suite, or `--skip-tests` to run none.
 
-!!! important
-
-    `--skip-backfill` / `--dry-run` plans skip unit tests by default. Pass `--all-tests` if you still want the full suite to run.
-
 For more information about tests, refer to [testing](../concepts/tests.md).
 
 ### Test changes to a specific model

docs/reference/cli.md

@@ -373,8 +373,7 @@ Options:
                                   when comparing to existing snapshots for
                                   matching models in the target environment.
   --skip-backfill, --dry-run      Skip the backfill step and only create a
-                                  virtual update for the plan. Unit tests are
-                                  also skipped unless --all-tests is passed.
+                                  virtual update for the plan.
   --empty-backfill                Produce empty backfill. Like --skip-backfill
                                   no models will be backfilled, unlike --skip-
                                   backfill missing intervals will be recorded

docs/reference/notebook.md

@@ -134,8 +134,7 @@ options:
                         the target environment.
   --skip-backfill, --dry-run
                         Skip the backfill step and only create a virtual
-                        update for the plan. Unit tests are also skipped
-                        unless --all-tests is passed.
+                        update for the plan.
   --forward-only        Create a plan for forward-only changes.
   --effective-from EFFECTIVE_FROM
                         The effective date from which to apply forward-only

sqlmesh/cli/main.py

@@ -452,7 +452,7 @@ def diff(ctx: click.Context, environment: t.Optional[str] = None) -> None:
     "--skip-backfill",
     "--dry-run",
     is_flag=True,
-    help="Skip the backfill step and only create a virtual update for the plan. Unit tests are also skipped unless --all-tests is passed.",
+    help="Skip the backfill step and only create a virtual update for the plan.",
     default=None,
 )
 @click.option(

sqlmesh/core/context.py

@@ -1606,10 +1606,6 @@ def plan_builder(
         skip_linter = skip_linter or False
         min_intervals = min_intervals or 0
 
-        # Virtual-only plans (--skip-backfill / --dry-run) skip unit tests unless --all-tests.
-        if skip_backfill and not all_tests:
-            skip_tests = True
-
         environment = environment or self.config.default_target_environment
         environment = Environment.sanitize_name(environment)
         is_dev = environment != c.PROD

sqlmesh/magics.py

@@ -434,7 +434,7 @@ def test(self, context: Context, line: str, test_def_raw: t.Optional[str] = None
         "--skip-backfill",
         "--dry-run",
         action="store_true",
-        help="Skip the backfill step and only create a virtual update for the plan. Unit tests are also skipped unless --all-tests is passed.",
+        help="Skip the backfill step and only create a virtual update for the plan.",
     )
     @argument(
         "--empty-backfill",

tests/cli/test_cli.py

@@ -274,27 +274,6 @@ def test_plan_runs_only_changed_model_tests(runner, tmp_path):
     assert "Successfully Ran 2 tests against duckdb" in result.output
 
 
-def test_plan_skip_backfill_all_tests(runner, tmp_path):
-    create_example_project(tmp_path)
-
-    result = runner.invoke(
-        cli,
-        [
-            "--log-file-dir",
-            tmp_path,
-            "--paths",
-            tmp_path,
-            "plan",
-            "--skip-backfill",
-            "--no-gaps",
-            "--all-tests",
-        ],
-        input="y\n",
-    )
-    assert result.exit_code == 0
-    assert "Successfully Ran 1 tests against duckdb" in result.output
-
-
 def test_plan_skip_linter(runner, tmp_path):
     create_example_project(tmp_path)
 
@@ -363,8 +342,8 @@ def test_plan_skip_backfill(runner, tmp_path, flag):
     assert result.exit_code == 0
     assert_virtual_layer_updated(result)
     assert "Model batches executed" not in result.output
-    # --skip-backfill / --dry-run skips unit tests by default
-    assert "Successfully Ran" not in result.output
+    # Dry-run still runs plan-scoped unit tests
+    assert "Successfully Ran 1 tests against duckdb" in result.output
 
 
 def test_plan_min_intervals(runner, tmp_path):