refactor(engine_adapter): add set_default_catalog instead of poking _default_catalog

Cleanup for expired environments needed to override a cloned adapter's
default catalog, but with_settings() hardcodes default_catalog from the
source adapter, leaving no public way to override it. Add a small setter
instead of reaching into the private attribute directly.

Signed-off-by: mday-io <mdaytn@gmail.com>

Author: mday-io

sqlmesh/core/context.py

@@ -3181,9 +3181,9 @@ def _cleanup_adapters_for_environment(
             cleanup_adapter = engine_adapters.get(gateway, default_adapter).with_settings()
             cleanup_adapter.inject_virtual_catalog(gateway)
             # inject_virtual_catalog() may initialize adapter-specific state in addition to
-            # _default_catalog. Override only the cleanup clone with the catalog persisted in the
-            # expired environment so historical names pass SINGLE_CATALOG_ONLY validation.
-            cleanup_adapter._default_catalog = next(iter(catalogs))
+            # the default catalog. Override only the cleanup clone with the catalog persisted
+            # in the expired environment so historical names pass SINGLE_CATALOG_ONLY validation.
+            cleanup_adapter.set_default_catalog(next(iter(catalogs)))
             cleanup_engine_adapters[gateway] = cleanup_adapter
             if gateway == self.selected_gateway:
                 cleanup_default_adapter = cleanup_adapter

sqlmesh/core/engine_adapter/base.py

@@ -295,6 +295,14 @@ def default_catalog(self) -> t.Optional[str]:
             )
         return default_catalog
 
+    def set_default_catalog(self, catalog: t.Optional[str]) -> None:
+        """Override this adapter's default catalog.
+
+        Used e.g. by janitor cleanup to restore a historical catalog name on a
+        cloned adapter when cleaning up an expired environment's virtual catalog.
+        """
+        self._default_catalog = catalog
+
     @property
     def engine_run_mode(self) -> EngineRunMode:
         return EngineRunMode.SINGLE_MODE_ENGINE