Skip to content

core action uses undefined pr-branch input for push #46

@ricogu-claw

Description

@ricogu-claw

Summary

The core action uses core.getInput('pr-branch') for dry-run logging and for git.push, but pr-branch is not defined as an input in either the top-level action metadata or the core action metadata.

Evidence

In .github/actions/core/src/index.ts:

core.info(`[DRY-RUN] Would push changes to origin/${core.getInput('pr-branch')}`);
...
await git.push('origin', core.getInput('pr-branch'));

However, neither action.yml nor .github/actions/core/action.yml defines a pr-branch input.

Why this matters

This makes the push logic depend on an undefined input instead of the branch information that is already available from the event/environment (GITHUB_HEAD_REF, GITHUB_REF_NAME, etc.). It is brittle and can lead to confusing behavior.

Expected behavior

The action should push back to the PR branch determined from the GitHub event/environment, without relying on an undeclared input.

Possible fix

  • Capture the resolved PR branch once during setup/configuration
  • Reuse that value for logging and git.push
  • Add a regression test around branch resolution/push target selection

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions