fix: fix code quality cjecks

Author: betinacosta

src/sap_cloud_sdk/adms/_async_http.py

@@ -29,6 +29,7 @@
 from __future__ import annotations
 
 import asyncio
+import inspect
 from typing import Any, Callable, Dict, Optional
 
 import httpx
@@ -216,7 +217,7 @@ async def _bearer_token(self) -> Optional[str]:
         """Resolve the bearer token, handling both sync and async callables."""
         if self._get_token is None:
             return None
-        if asyncio.iscoroutinefunction(self._get_token):
+        if inspect.iscoroutinefunction(self._get_token):
             return await self._get_token()
         return await asyncio.to_thread(self._get_token)
 

src/sap_cloud_sdk/core/data_anonymization/_http_transport.py

@@ -182,10 +182,10 @@ def _post_file_request(
         try:
             if request.file_path is not None:
                 file_handle = open(request.file_path, "rb")
-                file_value = file_handle
-            else:
-                file_value = request.file_content
 
+            file_value: BinaryIO | bytes = (
+                file_handle if file_handle is not None else request.file_content or b""
+            )
             files = {
                 "file": (
                     request.resolved_file_name(),

tests/core/unit/data_anonymization/test_http_transport.py

@@ -279,6 +279,7 @@ def test_resolve_cert_from_destination(
         transport._tmp_key_file = None
 
         cert_path = transport._resolve_cert()
+        assert isinstance(cert_path, str)
 
         assert Path(cert_path).exists()
         assert "BEGIN RSA PRIVATE KEY" in Path(cert_path).read_text(encoding="utf-8")
@@ -328,6 +329,7 @@ def test_resolve_cert_from_destination_with_base64_bundle(
         transport._tmp_key_file = None
 
         cert_path = transport._resolve_cert()
+        assert isinstance(cert_path, str)
 
         assert Path(cert_path).exists()
         assert "BEGIN CERTIFICATE" in Path(cert_path).read_text(encoding="utf-8")
@@ -373,7 +375,7 @@ def test_decode_destination_certificate_content_rejects_missing_key(self) -> Non
 
     def test_resolve_cert_without_config_raises(self) -> None:
         transport = object.__new__(HttpTransport)
-        transport._config = types.SimpleNamespace(
+        transport._config = types.SimpleNamespace(  # ty: ignore[invalid-assignment]
             cert=None,
             key=None,
             cert_path=None,

tests/objectstore/unit/test_s3_client.py

@@ -96,7 +96,7 @@ def test_put_object_from_bytes_validation(self, mock_minio_class):
     @patch('sap_cloud_sdk.objectstore._s3.Minio')
     def test_put_object_from_bytes_s3_error(self, mock_minio_class):
         mock_minio = Mock()
-        s3_error = S3Error("AccessDenied", "Access denied", "test.txt", "123", "456", Mock())
+        s3_error = S3Error(Mock(), "AccessDenied", "Access denied", "test.txt", "123", "456")
         mock_minio.put_object.side_effect = s3_error
         mock_minio_class.return_value = mock_minio
 
@@ -237,7 +237,7 @@ def test_list_objects_success(self, mock_minio_class):
     @patch('sap_cloud_sdk.objectstore._s3.Minio')
     def test_list_objects_s3_error(self, mock_minio_class):
         mock_minio = Mock()
-        s3_error = S3Error("AccessDenied", "Access denied", "", "123", "456", Mock())
+        s3_error = S3Error(Mock(), "AccessDenied", "Access denied", "", "123", "456")
         mock_minio.list_objects.side_effect = s3_error
         mock_minio_class.return_value = mock_minio