Skip to content

Commit a098c70

Browse files
fix(asap-tools): point the sketchdb arm at ASAPQuery's SQL endpoint
The engine's ClickHouse adapter serves SQL at /clickhouse/query; the query client posted to the server URL's root, so every sketchdb query got a 404. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 0097b53 commit a098c70

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

‎asap-tools/experiments/datasets/fake_metric/sketch_bench_workloads.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@
9898

9999
OUT_CONFIG_DIR = "config/experiment_type/sketch_bench_clickhouse"
100100
CLICKHOUSE_URL = "http://localhost:8123"
101-
ASAP_URL = "http://localhost:8088"
101+
# ASAPQuery's ClickHouse adapter serves SQL here, not at ClickHouse's `/`.
102+
ASAP_URL = "http://localhost:8088/clickhouse/query"
102103
# Seconds after an eval time the client sends it, so data up to the eval
103104
# time has arrived.
104105
QUERY_TIME_OFFSET_SECS = 10

‎asap-tools/experiments/tests/test_sketch_bench_workloads.py‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -501,6 +501,11 @@ def test_sketchdb_arm_runs_the_structured_queries_on_the_saved_plan(self):
501501
{"mode": "sketchdb", "server": "asap"},
502502
],
503503
)
504+
# The engine serves SQL at /clickhouse/query and 404s at `/`.
505+
self.assertIn(
506+
{"name": "asap", "url": "http://localhost:8088/clickhouse/query"},
507+
ep["servers"],
508+
)
504509
validate_experiment_config(OmegaConf.create(ep))
505510

506511
out = os.path.join(tmp, "out")

0 commit comments

Comments
 (0)