Guard closed pull request label events

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: MariusStorhaug

.github/actions/Get-PSModuleSettings/src/Get-PSModuleSettings.Helpers.psm1

@@ -15,6 +15,9 @@ function Resolve-WorkflowEventRouting {
         [Parameter()]
         [bool] $PullRequestIsMerged,
 
+        [Parameter()]
+        [bool] $PullRequestIsClosed,
+
         [Parameter()]
         [bool] $IsTargetDefaultBranch,
 
@@ -34,8 +37,9 @@ function Resolve-WorkflowEventRouting {
     $isPR = $EventName -eq 'pull_request'
     $isPush = $EventName -eq 'push'
     $isManualDispatch = $EventName -eq 'workflow_dispatch'
-    $isOpenOrUpdatedPR = $isPR -and $EventAction -in @('opened', 'reopened', 'synchronize', 'labeled', 'unlabeled')
-    $isOpenOrLabeledPR = $isPR -and $EventAction -in @('opened', 'reopened', 'synchronize', 'labeled')
+    $isActivePR = $isPR -and -not $PullRequestIsClosed
+    $isOpenOrUpdatedPR = $isActivePR -and $EventAction -in @('opened', 'reopened', 'synchronize', 'labeled', 'unlabeled')
+    $isOpenOrLabeledPR = $isActivePR -and $EventAction -in @('opened', 'reopened', 'synchronize', 'labeled')
     $isClosedPR = $isPR -and $EventAction -eq 'closed'
     $isAbandonedPR = $isClosedPR -and -not $PullRequestIsMerged
     $isMergedPR = $isClosedPR -and $PullRequestIsMerged
@@ -65,7 +69,11 @@ function Resolve-WorkflowEventRouting {
         } else {
             'None'
         }
-        ShouldRunBuildTest              = (-not $isClosedPR) -and $HasImportantChanges
+        ShouldRunBuildTest              = (
+            -not $isClosedPR -and
+            ((-not $isPR) -or (-not $PullRequestIsClosed)) -and
+            $HasImportantChanges
+        )
         ShouldCleanupEvent              = $isClosedPR
     }
 }

.github/actions/Get-PSModuleSettings/src/main.ps1

@@ -267,6 +267,7 @@ LogGroup 'Calculate Job Run Conditions:' {
     } else {
         -not [string]::IsNullOrWhiteSpace($pullRequest.merged_at)
     }
+    $pullRequestIsClosed = $null -ne $pullRequest -and $pullRequest.State -eq 'closed'
     $targetBranch = if ($pullRequest) { $pullRequest.Base.Ref } elseif ($isPush) { $pushBranch } else { $workflowRef }
     $isTargetDefaultBranch = $targetBranch -eq $defaultBranch
     $pullRequestContext = if ($pullRequest) {
@@ -278,6 +279,7 @@ LogGroup 'Calculate Job Run Conditions:' {
             BaseRef        = $pullRequest.Base.Ref
             Labels         = @($pullRequest.Labels.Name)
             Merged         = $pullRequestIsMerged
+            Closed         = $pullRequestIsClosed
             MergeCommitSha = $pullRequest.merge_commit_sha
             HtmlUrl        = $pullRequest.html_url
         }
@@ -301,6 +303,7 @@ LogGroup 'Calculate Job Run Conditions:' {
         GITHUB_EVENT_NAME                = $eventName
         GITHUB_EVENT_ACTION              = $pullRequestAction
         GITHUB_EVENT_PULL_REQUEST_MERGED = $pullRequestIsMerged
+        GITHUB_EVENT_PULL_REQUEST_CLOSED = $pullRequestIsClosed
         CommitSha                        = $commitSha
         PushBranch                       = $pushBranch
         TargetBranch                     = $targetBranch
@@ -439,6 +442,7 @@ If you believe this is incorrect, please verify that your changes are in the cor
     $routing = Resolve-WorkflowEventRouting -EventName $eventName `
         -EventAction $pullRequestAction `
         -PullRequestIsMerged $pullRequestIsMerged `
+        -PullRequestIsClosed $pullRequestIsClosed `
         -IsTargetDefaultBranch $isTargetDefaultBranch `
         -IsPushToDefaultBranch $isPushToDefaultBranch `
         -IsManualDispatchToDefaultBranch $isManualDispatchToDefaultBranch `

.github/actions/Get-PSModuleSettings/tests/Get-PSModuleSettings.Helpers.Tests.ps1

@@ -63,6 +63,20 @@ Describe 'Resolve-WorkflowEventRouting' {
         $result.ShouldRunBuildTest | Should -BeFalse
         $result.ShouldCleanupEvent | Should -BeTrue
     }
+
+    It 'does not run a label event for a closed PR' {
+        $result = Resolve-WorkflowEventRouting -EventName pull_request `
+            -EventAction labeled `
+            -PullRequestIsClosed $true `
+            -IsTargetDefaultBranch $true `
+            -HasImportantChanges $true `
+            -HasPrereleaseLabel $true
+
+        $result.ReleaseType | Should -Be 'None'
+        $result.IsOpenOrUpdatedPR | Should -BeFalse
+        $result.ShouldRunBuildTest | Should -BeFalse
+        $result.ShouldCleanupEvent | Should -BeFalse
+    }
 }
 
 Describe 'Select-PullRequestForPush' {