Rhino: migrate from servicemix to org.mozilla#189
Merged
maximthomas merged 5 commits intoJun 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the previous Apache ServiceMix Rhino OSGi bundle dependency with a new in-repo openidm-rhino OSGi wrapper module around Mozilla Rhino, and updates downstream modules/assembly to consume it.
Changes:
- Removed
org.apache.servicemix.bundles.rhinofrom the root/UI builds and introduced a newopenidm-rhinoreactor module. - Wired
openidm-rhinointo the runtime ZIP build and updated the ZIP assembly excludes fororg.mozilla:rhino*. - Added a
graal-sdktest dependency toopenidm-repo-orientdb.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Drops ServiceMix Rhino management and adds the new openidm-rhino module to the reactor. |
| openidm-zip/src/main/assembly/zip.xml | Excludes org.mozilla:rhino* from the runtime dependency set in the ZIP assembly. |
| openidm-zip/pom.xml | Adds openidm-rhino to the ZIP assembly dependencies. |
| openidm-util/pom.xml | Replaces ServiceMix Rhino with the new openidm-rhino bundle dependency. |
| openidm-ui/openidm-ui-enduser/pom.xml | Removes the ServiceMix Rhino dependency from the UI enduser module. |
| openidm-ui/openidm-ui-admin/pom.xml | Removes the ServiceMix Rhino dependency from the UI admin module. |
| openidm-rhino/pom.xml | Introduces a new OSGi bundle wrapper intended to embed Mozilla Rhino artifacts. |
| openidm-repo-orientdb/pom.xml | Adds org.graalvm.sdk:graal-sdk as a test-scoped dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+31
to
+54
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.mozilla</groupId> | ||
| <artifactId>rhino</artifactId> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.mozilla</groupId> | ||
| <artifactId>rhino-engine</artifactId> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| </dependencies> | ||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.felix</groupId> | ||
| <artifactId>maven-bundle-plugin</artifactId> | ||
| <extensions>true</extensions> | ||
| <configuration> | ||
| <instructions> | ||
| <Bundle-Name>${project.name}</Bundle-Name> | ||
| <Bundle-SymbolicName>${project.name}</Bundle-SymbolicName> | ||
| <Embed-Dependency>*;groupId=org.mozilla;inline=true</Embed-Dependency> | ||
| <Export-Package>*</Export-Package> |
Contributor
Author
There was a problem hiding this comment.
rhino components version is already declared in the commons project, see OpenIdentityPlatform/commons#181
suggestion
<Embed-Dependency>*;groupId=org.mozilla;inline=true;scope=provided</Embed-Dependency>
seems reasonable.
vharseko
changed the title
vharseko
approved these changes
Jun 9, 2026
vharseko
approved these changes
Jun 9, 2026
maximthomas
merged commit 23c68ee
into
OpenIdentityPlatform:master
59 of 60 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.