fix: pnpm installs hang forever - close stdin, harden the pnpm backend

pnpm 10/11 never exits while its stdin is an open pipe, so every
CLI-fired install (ns run/debug --force, ns install, plugin add)
finished its work and then hung the CLI on the child's "close" event.
Non-interactive installs now spawn with stdin ignored.

Also in the pnpm backend:
- pass --shamefully-hoist only when no pnpm-workspace.yaml or .npmrc
  layout key (node-linker, shamefully-hoist, hoist*) governs the
  install dir: pnpm treats a contradicting hoist flag as a config
  change and rebuilds node_modules, aborting when there is no TTY
- drop CLI-internal options (ignoreScripts, path, frameworkPath)
  before flag serialization: pnpm hard-fails on unknown options
  where npm silently accepts them
- getCachePath: `pnpm config get cache` prints "undefined" (pnpm has
  no cache key), yielding a relative junk path for pacote; fall back
  to the parent of `pnpm store path`

Author: NathanWalker

lib/base-package-manager.ts

@@ -17,17 +17,17 @@ export abstract class BasePackageManager implements INodePackageManager {
 	public abstract install(
 		packageName: string,
 		pathToSave: string,
-		config: INodePackageManagerInstallOptions
+		config: INodePackageManagerInstallOptions,
 	): Promise<INpmInstallResultInfo>;
 	public abstract uninstall(
 		packageName: string,
 		config?: IDictionary<string | boolean>,
-		path?: string
+		path?: string,
 	): Promise<string>;
 	public abstract view(packageName: string, config: Object): Promise<any>;
 	public abstract search(
 		filter: string[],
-		config: IDictionary<string | boolean>
+		config: IDictionary<string | boolean>,
 	): Promise<string>;
 	public abstract searchNpms(keyword: string): Promise<INpmsResult>;
 	public abstract getRegistryPackageData(packageName: string): Promise<any>;
@@ -38,7 +38,7 @@ export abstract class BasePackageManager implements INodePackageManager {
 		protected $fs: IFileSystem,
 		private $hostInfo: IHostInfo,
 		private $pacoteService: IPacoteService,
-		private packageManager: string
+		private packageManager: string,
 	) {}
 
 	public async isRegistered(packageName: string): Promise<boolean> {
@@ -65,7 +65,7 @@ export abstract class BasePackageManager implements INodePackageManager {
 	}
 
 	public async getPackageNameParts(
-		fullPackageName: string
+		fullPackageName: string,
 	): Promise<INpmPackageNameParts> {
 		// support <reserved_name>@<version> syntax, for example typescript@1.0.0
 		// support <scoped_package_name>@<version> syntax, for example @nativescript/vue-template@1.0.0
@@ -84,7 +84,7 @@ export abstract class BasePackageManager implements INodePackageManager {
 	}
 
 	public async getPackageFullName(
-		packageNameParts: INpmPackageNameParts
+		packageNameParts: INpmPackageNameParts,
 	): Promise<string> {
 		return packageNameParts.version
 			? `${packageNameParts.name}@${packageNameParts.version}`
@@ -104,10 +104,15 @@ export abstract class BasePackageManager implements INodePackageManager {
 	protected async processPackageManagerInstall(
 		packageName: string,
 		params: string[],
-		opts: { cwd: string; isInstallingAllDependencies: boolean }
+		opts: { cwd: string; isInstallingAllDependencies: boolean },
 	): Promise<INpmInstallResultInfo> {
 		const npmExecutable = this.getPackageManagerExecutableName();
-		const stdioValue = isInteractive() ? "inherit" : "pipe";
+		// stdin must be closed, not an open pipe: pnpm keeps the process alive
+		// listening on a piped stdin after the install completes, so waiting for
+		// "close" would hang forever.
+		const stdioValue: any = isInteractive()
+			? "inherit"
+			: ["ignore", "pipe", "pipe"];
 		await this.$childProcess.spawnFromEvent(npmExecutable, params, "close", {
 			cwd: opts.cwd,
 			stdio: stdioValue,

lib/pnpm-package-manager.ts

@@ -26,7 +26,7 @@ export class PnpmPackageManager extends BasePackageManager {
 		$hostInfo: IHostInfo,
 		private $httpClient: Server.IHttpClient,
 		private $logger: ILogger,
-		$pacoteService: IPacoteService
+		$pacoteService: IPacoteService,
 	) {
 		super($childProcess, $fs, $hostInfo, $pacoteService, "pnpm");
 	}
@@ -35,7 +35,7 @@ export class PnpmPackageManager extends BasePackageManager {
 	public async install(
 		packageName: string,
 		pathToSave: string,
-		config: INodePackageManagerInstallOptions
+		config: INodePackageManagerInstallOptions,
 	): Promise<INpmInstallResultInfo> {
 		if (config.disableNpmInstall) {
 			return;
@@ -44,13 +44,25 @@ export class PnpmPackageManager extends BasePackageManager {
 		if (config.ignoreScripts) {
 			config["ignore-scripts"] = true;
 		}
+		// CLI-internal options must never reach the command line: pnpm, unlike
+		// npm, hard-fails on unknown options.
+		delete config.ignoreScripts;
+		delete config.path;
+		delete config.frameworkPath;
 
 		const packageJsonPath = path.join(pathToSave, "package.json");
 		const jsonContentBefore = this.$fs.readJson(packageJsonPath);
 
 		const flags = this.getFlagsString(config, true);
-		// With pnpm we need to install as "flat" or some imports wont be found
-		let params = ["i", "--shamefully-hoist"];
+		let params = ["i"];
+		if (!this.projectManagesOwnHoisting(pathToSave)) {
+			// With pnpm's default isolated layout some imports won't be found, so
+			// install "flat". Skipped when the project configures its own layout:
+			// pnpm treats a hoisting flag that contradicts the stored install state
+			// as a config change and rebuilds node_modules from scratch after a
+			// prompt (aborting outright when there is no TTY).
+			params.push("--shamefully-hoist");
+		}
 		const isInstallingAllDependencies = packageName === pathToSave;
 		if (!isInstallingAllDependencies) {
 			params.push(packageName);
@@ -63,7 +75,7 @@ export class PnpmPackageManager extends BasePackageManager {
 			const result = await this.processPackageManagerInstall(
 				packageName,
 				params,
-				{ cwd, isInstallingAllDependencies }
+				{ cwd, isInstallingAllDependencies },
 			);
 			return result;
 		} catch (e) {
@@ -76,7 +88,7 @@ export class PnpmPackageManager extends BasePackageManager {
 	public uninstall(
 		packageName: string,
 		config?: IDictionary<string | boolean>,
-		cwd?: string
+		cwd?: string,
 	): Promise<string> {
 		// pnpm does not want save option in remove. It saves it by default
 		delete config["save"];
@@ -94,7 +106,7 @@ export class PnpmPackageManager extends BasePackageManager {
 		let viewResult: any;
 		try {
 			viewResult = await this.$childProcess.exec(
-				`pnpm info ${packageName} ${flags}`
+				`pnpm info ${packageName} ${flags}`,
 			);
 		} catch (e) {
 			this.$errors.fail(e.message);
@@ -110,15 +122,15 @@ export class PnpmPackageManager extends BasePackageManager {
 	@exported("pnpm")
 	public search(
 		filter: string[],
-		config: IDictionary<string | boolean>
+		config: IDictionary<string | boolean>,
 	): Promise<string> {
 		const flags = this.getFlagsString(config, false);
 		return this.$childProcess.exec(`pnpm search ${filter.join(" ")} ${flags}`);
 	}
 
 	public async searchNpms(keyword: string): Promise<INpmsResult> {
 		const httpRequestResult = await this.$httpClient.httpRequest(
-			`https://api.npms.io/v2/search?q=keywords:${keyword}`
+			`https://api.npms.io/v2/search?q=keywords:${keyword}`,
 		);
 		const result: INpmsResult = JSON.parse(httpRequestResult.body);
 		return result;
@@ -129,23 +141,60 @@ export class PnpmPackageManager extends BasePackageManager {
 		const registry = await this.$childProcess.exec(`pnpm config get registry`);
 		const url = `${registry.trim()}/${packageName}`;
 		this.$logger.trace(
-			`Trying to get data from pnpm registry for package ${packageName}, url is: ${url}`
+			`Trying to get data from pnpm registry for package ${packageName}, url is: ${url}`,
 		);
 		const responseData = (await this.$httpClient.httpRequest(url)).body;
 		this.$logger.trace(
-			`Successfully received data from pnpm registry for package ${packageName}. Response data is: ${responseData}`
+			`Successfully received data from pnpm registry for package ${packageName}. Response data is: ${responseData}`,
 		);
 		const jsonData = JSON.parse(responseData);
 		this.$logger.trace(
-			`Successfully parsed data from pnpm registry for package ${packageName}.`
+			`Successfully parsed data from pnpm registry for package ${packageName}.`,
 		);
 		return jsonData;
 	}
 
 	@exported("pnpm")
 	public async getCachePath(): Promise<string> {
 		const cachePath = await this.$childProcess.exec(`pnpm config get cache`);
-		return path.join(cachePath.trim(), CACACHE_DIRECTORY_NAME);
+		const cacheDir = cachePath && cachePath.trim();
+		// pnpm has no `cache` config key of its own: modern versions print
+		// "undefined" (older ones an empty string), which would yield a relative
+		// garbage path. Derive a stable per-user location from the store instead.
+		if (cacheDir && cacheDir !== "undefined" && cacheDir !== "null") {
+			return path.join(cacheDir, CACACHE_DIRECTORY_NAME);
+		}
+		const storePath = await this.$childProcess.exec(`pnpm store path`);
+		return path.join(path.dirname(storePath.trim()), CACACHE_DIRECTORY_NAME);
+	}
+
+	private projectManagesOwnHoisting(installDir: string): boolean {
+		// A pnpm-workspace.yaml (pnpm's config home since v10) or an .npmrc with
+		// a layout key marks the node_modules layout as the project's own choice.
+		const layoutKeyPattern =
+			/^\s*(shamefully-hoist|node-linker|hoist|hoist-pattern|public-hoist-pattern)\s*[=:]/m;
+		let dir = path.resolve(installDir);
+		while (true) {
+			if (this.$fs.exists(path.join(dir, "pnpm-workspace.yaml"))) {
+				return true;
+			}
+			const npmrcPath = path.join(dir, ".npmrc");
+			if (this.$fs.exists(npmrcPath)) {
+				try {
+					const npmrcContent = this.$fs.readText(npmrcPath);
+					if (npmrcContent && layoutKeyPattern.test(npmrcContent)) {
+						return true;
+					}
+				} catch (err) {
+					this.$logger.trace(`Unable to read ${npmrcPath}. Error is: `, err);
+				}
+			}
+			const parent = path.dirname(dir);
+			if (parent === dir) {
+				return false;
+			}
+			dir = parent;
+		}
 	}
 }