fix: recognize .npmrc array-valued hoist keys; make stdio test TTY-independent

Review follow-ups: hoist-pattern[]= / public-hoist-pattern[]= (the .npmrc
array syntax) now count as user-managed layout config, and the stdin test
forces non-interactive mode via setIsInteractive so it passes from a TTY.

Author: NathanWalker

lib/pnpm-package-manager.ts

@@ -171,8 +171,9 @@ export class PnpmPackageManager extends BasePackageManager {
 	private projectManagesOwnHoisting(installDir: string): boolean {
 		// A pnpm-workspace.yaml (pnpm's config home since v10) or an .npmrc with
 		// a layout key marks the node_modules layout as the project's own choice.
+		// The optional [] suffix covers .npmrc's array syntax (hoist-pattern[]=).
 		const layoutKeyPattern =
-			/^\s*(shamefully-hoist|node-linker|hoist|hoist-pattern|public-hoist-pattern)\s*[=:]/m;
+			/^\s*(shamefully-hoist|node-linker|hoist|hoist-pattern|public-hoist-pattern)(\[\])?\s*[=:]/m;
 		let dir = path.resolve(installDir);
 		while (true) {
 			if (this.$fs.exists(path.join(dir, "pnpm-workspace.yaml"))) {

package.json

@@ -1,7 +1,7 @@
 {
   "name": "nativescript",
   "main": "./dist/lib/nativescript-cli-lib.js",
-  "version": "9.1.1-dev.0",
+  "version": "9.1.0",
   "author": "NativeScript <oss@nativescript.org>",
   "description": "Command-line interface for building NativeScript projects",
   "bin": {

test/pnpm-package-manager.ts

@@ -2,6 +2,7 @@ import * as path from "path";
 import { Yok } from "../lib/common/yok";
 import * as stubs from "./stubs";
 import { assert } from "chai";
+import { setIsInteractive } from "../lib/common/helpers";
 import { PnpmPackageManager } from "../lib/pnpm-package-manager";
 import { IInjector } from "../lib/common/definitions/yok";
 
@@ -133,6 +134,24 @@ describe("pnpm-package-manager", () => {
 			assert.deepEqual(childProcess.spawnedArgs[0], ["i"]);
 		});
 
+		["hoist-pattern[]", "public-hoist-pattern[]"].forEach((layoutKey) => {
+			it(`omits --shamefully-hoist when an .npmrc sets array-valued ${layoutKey}`, async () => {
+				const testInjector = createTestInjector();
+				const pnpm = testInjector.resolve<PnpmPackageManager>("pnpm");
+				const childProcess =
+					testInjector.resolve<RecordingChildProcessStub>("childProcess");
+				const fs = testInjector.resolve<SelectiveFileSystemStub>("fs");
+				const npmrcPath = path.join(projectDir, ".npmrc");
+				fs.existingPaths = [npmrcPath];
+				fs.textFiles[npmrcPath] =
+					`registry=https://example.com\n${layoutKey}=*types*\n`;
+
+				await pnpm.install(projectDir, projectDir, {} as any);
+
+				assert.deepEqual(childProcess.spawnedArgs[0], ["i"]);
+			});
+		});
+
 		it("keeps --shamefully-hoist when an .npmrc has no layout key", async () => {
 			const testInjector = createTestInjector();
 			const pnpm = testInjector.resolve<PnpmPackageManager>("pnpm");
@@ -176,7 +195,12 @@ describe("pnpm-package-manager", () => {
 			const childProcess =
 				testInjector.resolve<RecordingChildProcessStub>("childProcess");
 
-			await pnpm.install(projectDir, projectDir, {} as any);
+			setIsInteractive(() => false);
+			try {
+				await pnpm.install(projectDir, projectDir, {} as any);
+			} finally {
+				setIsInteractive(undefined);
+			}
 
 			// pnpm never exits while its stdin is an open pipe, so anything but
 			// "ignore" here hangs the CLI's wait for the child's "close" event.