Django 5 upgrade#404
Open
duckduckgrayduck wants to merge 46 commits into
Open
Conversation
…low ANTIALIAS removal
…ped in 3.12 in hopes of fixing lambda
…the distutils to be missing
duckduckgrayduck
force-pushed
the
django_5_upgrade
branch
2 times, most recently
from
3401e7e to
ac30f13
Compare
duckduckgrayduck
force-pushed
the
django_5_upgrade
branch
from
fc1b323 to
cdf6fc2
Compare
eyeseast
reviewed
May 28, 2026
eyeseast
reviewed
May 28, 2026
eyeseast
reviewed
May 28, 2026
Co-authored-by: Chris Amico <eyeseast@gmail.com>
Co-authored-by: Chris Amico <eyeseast@gmail.com>
eyeseast
reviewed
May 28, 2026
Contributor
|
I've looked at every file. The only thing blocking is the |
eyeseast
approved these changes
May 28, 2026
mitchelljkotler
approved these changes
Jun 9, 2026
| # Django REST Framework | ||
| djangorestframework | ||
| rest-social-auth | ||
| social-auth-core[openidconnect] |
Member
There was a problem hiding this comment.
Why was openidconnect dropped here?
Contributor
Author
There was a problem hiding this comment.
It was dropped as an extra. No extras are needed anymore. See:
python-social-auth/social-docs#274
&
nautobot/nautobot#5565
| from djchoices import ChoiceItem, DjangoChoices | ||
|
|
||
| class Event(models.IntegerChoices): | ||
| def __new__(cls, value, label=None, api=False): |
Member
There was a problem hiding this comment.
This __new__ method is duplicated in every choices model. It could be turned into a mixin instead. Not blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(requires the corresponding Accounts fix