From 60887d75ad619e638a6fe1b298d532abd93582fb Mon Sep 17 00:00:00 2001 From: Martix Date: Thu, 12 Nov 2026 17:50:36 +0100 Subject: [PATCH 1/3] Fix replacing selected numeric values in WTextBox --- .../gui/widgets/input/WDoubleEdit.java | 2 +- .../gui/widgets/input/WIntEdit.java | 2 +- .../gui/widgets/input/WLongEdit.java | 2 +- .../gui/widgets/input/WTextBox.java | 27 ++++++++++++------- 4 files changed, 21 insertions(+), 12 deletions(-) diff --git a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WDoubleEdit.java b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WDoubleEdit.java index dd069183699..5d8ce011d6a 100644 --- a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WDoubleEdit.java +++ b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WDoubleEdit.java @@ -95,7 +95,7 @@ private boolean filter(String text, char c) { boolean good; boolean validate = true; - if (c == '-' && !text.contains("-") && textBox.cursor == 0) { + if (c == '-' && !text.contains("-") && Math.min(textBox.selectionStart, textBox.selectionEnd) == 0) { good = true; validate = false; } else if (c == '.' && !text.contains(".")) { diff --git a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WIntEdit.java b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WIntEdit.java index c6231b16193..41741f5fe75 100644 --- a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WIntEdit.java +++ b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WIntEdit.java @@ -82,7 +82,7 @@ private boolean filter(String text, char c) { boolean good; boolean validate = true; - if (c == '-' && !text.contains("-") && textBox.cursor == 0) { + if (c == '-' && !text.contains("-") && Math.min(textBox.selectionStart, textBox.selectionEnd) == 0) { good = true; validate = false; } diff --git a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WLongEdit.java b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WLongEdit.java index b1f0b283101..50accf82fe9 100644 --- a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WLongEdit.java +++ b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WLongEdit.java @@ -54,7 +54,7 @@ private boolean filter(String text, char c) { boolean good; boolean validate = true; - if (c == '-' && !text.contains("-") && textBox.cursor == 0) { + if (c == '-' && !text.contains("-") && Math.min(textBox.selectionStart, textBox.selectionEnd) == 0) { good = true; validate = false; } else { diff --git a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WTextBox.java b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WTextBox.java index 318c45f8643..cc3b4ef245b 100644 --- a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WTextBox.java +++ b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WTextBox.java @@ -559,19 +559,28 @@ private int getSelectedCompletion() { public boolean onCharTyped(CharacterEvent input) { if (!focused) return false; - if (filter.filter(text, input.codepoint())) { - clearSelection(); + int start = Math.min(selectionStart, selectionEnd); + int end = Math.max(selectionStart, selectionEnd); - text = text.substring(0, cursor) + input.codepointAsString() + text.substring(cursor); + String newText = text; + if (start != end) { + newText = text.substring(0, start) + text.substring(end); + } - cursor++; - resetSelection(); + if (!filter.filter(newText, input.codepoint())) return false; - runAction(); - return true; - } + String inserted = input.codepointAsString(); - return false; + text = newText.substring(0, start) + + inserted + + newText.substring(start); + + cursor = start + inserted.length(); + + resetSelection(); + runAction(); + + return true; } @Override From 69b12b06b69e22d38e3523a963456f0c1aec4112 Mon Sep 17 00:00:00 2001 From: Martix Date: Sat, 14 Nov 2026 14:26:37 +0100 Subject: [PATCH 2/3] Validate numeric input at cursor position --- .../meteorclient/gui/widgets/input/WDoubleEdit.java | 8 +++++++- .../meteorclient/gui/widgets/input/WIntEdit.java | 8 +++++++- .../meteorclient/gui/widgets/input/WLongEdit.java | 8 +++++++- 3 files changed, 21 insertions(+), 3 deletions(-) diff --git a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WDoubleEdit.java b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WDoubleEdit.java index 5d8ce011d6a..5814f3a8a73 100644 --- a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WDoubleEdit.java +++ b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WDoubleEdit.java @@ -91,6 +91,12 @@ public void init() { } } + private String insertAtCursor(String text, char c) { + int cursor = Math.min(textBox.selectionStart, textBox.selectionEnd); + cursor = Math.clamp(cursor, 0, text.length()); + return text.substring(0, cursor) + c + text.substring(cursor); + } + private boolean filter(String text, char c) { boolean good; boolean validate = true; @@ -105,7 +111,7 @@ private boolean filter(String text, char c) { if (good && validate) { try { - Double.parseDouble(text + c); + Double.parseDouble(insertAtCursor(text, c)); } catch (NumberFormatException _) { good = false; } diff --git a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WIntEdit.java b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WIntEdit.java index 41741f5fe75..e6732e0299e 100644 --- a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WIntEdit.java +++ b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WIntEdit.java @@ -78,6 +78,12 @@ public void init() { } } + private String insertAtCursor(String text, char c) { + int cursor = Math.min(textBox.selectionStart, textBox.selectionEnd); + cursor = Math.clamp(cursor, 0, text.length()); + return text.substring(0, cursor) + c + text.substring(cursor); + } + private boolean filter(String text, char c) { boolean good; boolean validate = true; @@ -90,7 +96,7 @@ private boolean filter(String text, char c) { if (good && validate) { try { - Integer.parseInt(text + c); + Integer.parseInt(insertAtCursor(text, c)); } catch (NumberFormatException _) { good = false; } diff --git a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WLongEdit.java b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WLongEdit.java index 50accf82fe9..51d3aa61fe6 100644 --- a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WLongEdit.java +++ b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WLongEdit.java @@ -50,6 +50,12 @@ public void init() { }; } + private String insertAtCursor(String text, char c) { + int cursor = Math.min(textBox.selectionStart, textBox.selectionEnd); + cursor = Math.clamp(cursor, 0, text.length()); + return text.substring(0, cursor) + c + text.substring(cursor); + } + private boolean filter(String text, char c) { boolean good; boolean validate = true; @@ -63,7 +69,7 @@ private boolean filter(String text, char c) { if (good && validate) { try { - Long.parseLong(text + c); + Long.parseLong(insertAtCursor(text, c)); } catch (NumberFormatException _) { good = false; } From 2333f732aaae0aa51cd2fbd3913315f736742062 Mon Sep 17 00:00:00 2001 From: Martix Date: Wed, 18 Nov 2026 23:21:16 +0100 Subject: [PATCH 3/3] Allow typing decimal point after minus --- .../meteorclient/gui/widgets/input/WDoubleEdit.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WDoubleEdit.java b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WDoubleEdit.java index 5814f3a8a73..0eb4fd524c7 100644 --- a/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WDoubleEdit.java +++ b/src/main/java/meteordevelopment/meteorclient/gui/widgets/input/WDoubleEdit.java @@ -106,7 +106,7 @@ private boolean filter(String text, char c) { validate = false; } else if (c == '.' && !text.contains(".")) { good = true; - if (text.isEmpty()) validate = false; + if (text.isEmpty() || text.equals("-")) validate = false; } else good = Character.isDigit(c); if (good && validate) { @@ -149,4 +149,4 @@ public void set(double value) { private String valueString() { return String.format(Locale.US, "%." + decimalPlaces + "f", value); } -} +} \ No newline at end of file