From 8a627b719b0b65af402752d375e8bcbc817f8293 Mon Sep 17 00:00:00 2001 From: simpleqt <89645338+simpleqt@users.noreply.github.com> Date: Mon, 28 Sep 2026 15:39:37 +0800 Subject: [PATCH] fix(mem_os): strip only markdown fences in clean_json_response clean_json_response replaced every triple-backtick run in the response, so JSON string values that themselves contain fenced code (common when an LLM returns content with markdown snippets) were silently corrupted before json.loads. Strip only an opening fence (with its optional info string) at the very start and a closing fence at the very end. Red/green verified: the new test fails against the old implementation (interior fences removed) and passes with the fix. Signed-off-by: simpleqt <89645338+simpleqt@users.noreply.github.com> --- src/memos/mem_os/utils/format_utils.py | 9 +++++++-- tests/mem_os/test_format_utils.py | 20 ++++++++++++++++++++ 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/src/memos/mem_os/utils/format_utils.py b/src/memos/mem_os/utils/format_utils.py index 3991d0667..5a8de625f 100644 --- a/src/memos/mem_os/utils/format_utils.py +++ b/src/memos/mem_os/utils/format_utils.py @@ -1,5 +1,6 @@ import math import random +import re from typing import Any @@ -533,7 +534,7 @@ def convert_graph_to_tree_forworkmem( node_name = extract_node_name(memory) memory_key = node.get("metadata", {}).get("key", node_name) usage = node.get("metadata", {}).get("usage", []) - frequency = len(usage) if len(usage) < 100 else 100 + frequency = min(100, len(usage)) node_map[node["id"]] = { "id": node["id"], "value": memory, @@ -1413,4 +1414,8 @@ def clean_json_response(response: str) -> str: "failed silently (check timed_with_status / generate() error " "handling)." ) - return response.replace("```json", "").replace("```", "").strip() + # Only an opening fence (with its optional info string) at the very + # start and a closing fence at the very end are markdown markup. A + # global replace used to corrupt JSON string values that themselves + # contain fenced code, e.g. {"text": "```py\ncode```"}. + return re.sub(r"^```[^\n]*\n?|\n?```\s*$", "", response.strip()).strip() diff --git a/tests/mem_os/test_format_utils.py b/tests/mem_os/test_format_utils.py index b97178784..f1a715e6a 100644 --- a/tests/mem_os/test_format_utils.py +++ b/tests/mem_os/test_format_utils.py @@ -73,3 +73,23 @@ def test_clean_json_response_preserves_internal_backticks(self): result = clean_json_response(input_str) assert "`example`" in result assert result.count("`") == 2 # Only internal backticks remain + + +def test_interior_code_fences_preserved(): + """The old global replace("```", "") corrupted JSON string values that + contain markdown code fences themselves.""" + src = '```json\n{"text": "```py\\ncode```"}\n```' + assert clean_json_response(src) == '{"text": "```py\\ncode```"}' + + +def test_plain_fence_stripped(): + assert clean_json_response('```json\n{"a": 1}\n```') == '{"a": 1}' + assert clean_json_response('```\n{"a": 1}\n```') == '{"a": 1}' + + +def test_no_fence_unchanged(): + assert clean_json_response('{"a": 1}') == '{"a": 1}' + + +def test_opening_fence_only(): + assert clean_json_response('```json\n{"a": 1}') == '{"a": 1}'