From 5b2a0d8fbb72f76a0f065f9179772a425bd36432 Mon Sep 17 00:00:00 2001 From: sonimwang <17816198144@163.com> Date: Fri, 5 Jun 2026 12:34:45 +0800 Subject: [PATCH 1/4] docs(cn): translate remaining English text in dream.md --- docs/cn/open_source/modules/dream.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/cn/open_source/modules/dream.md b/docs/cn/open_source/modules/dream.md index a83beab42..55cd9e2cf 100644 --- a/docs/cn/open_source/modules/dream.md +++ b/docs/cn/open_source/modules/dream.md @@ -79,7 +79,7 @@ Dream 模拟这一点:从*未完成的内在动机*出发,而不是从原始 ```json { "motive_id": "motive:dream_memory_strategy_alignment", - "description": "Several conversations failed for the same hidden reason: weekly reporting, future planning, and filter design were treated as separate tasks, while the user needed a shared strategic narrative.", + "description": "几次对话失败,背后是同一个隐藏原因:周报、未来规划和 filter 设计被当成三个独立任务,而用户需要的是一条统一的战略叙事。", "memory_ids": ["weekly_report_thread", "future_planning_thread", "filter_design_thread"] } ``` From cc0fb714ef7fea53955973f7f04f8ffb659c5b76 Mon Sep 17 00:00:00 2001 From: harvey_xiang Date: Tue, 7 Jul 2026 17:17:16 +0800 Subject: [PATCH 2/4] chore: update github workflow stale.yaml --- .github/workflows/stale.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index b398497de..27b330aa9 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -20,8 +20,8 @@ jobs: close-pr-message: 'This PR has been automatically closed due to inactivity.' days-before-stale: 30 # Days of inactivity before marking as stale days-before-close: 7 # Days of inactivity before closing stale issues/PRs - stale-issue-label: 'stale' - stale-pr-label: 'stale' - exempt-issue-labels: 'do not close' - exempt-pr-labels: 'do not close' + stale-issue-label: 'status:stale' + stale-pr-label: 'status:stale' + exempt-issue-labels: 'status:do not close' + exempt-pr-labels: 'status:do not close' remove-stale-when-updated: true From 98e5fb7f934b0f3fb8c03ae5b6f2c868f31a3c53 Mon Sep 17 00:00:00 2001 From: Ziyang Guo <121015044+RerankerGuo@users.noreply.github.com> Date: Thu, 2 Jul 2026 22:50:32 +0800 Subject: [PATCH 3/4] fix: align Gemini viewer embedding test --- .../src/embedding/providers/gemini.ts | 2 +- apps/memos-local-openclaw/src/viewer/html.ts | 2 +- .../memos-local-openclaw/src/viewer/server.ts | 17 ++++++++++--- .../tests/gemini-viewer-test.test.ts | 24 +++++++++++++++++++ 4 files changed, 40 insertions(+), 5 deletions(-) create mode 100644 apps/memos-local-openclaw/tests/gemini-viewer-test.test.ts diff --git a/apps/memos-local-openclaw/src/embedding/providers/gemini.ts b/apps/memos-local-openclaw/src/embedding/providers/gemini.ts index 6156b8a7b..70eeaa1df 100644 --- a/apps/memos-local-openclaw/src/embedding/providers/gemini.ts +++ b/apps/memos-local-openclaw/src/embedding/providers/gemini.ts @@ -5,7 +5,7 @@ export async function embedGemini( cfg: EmbeddingConfig, log: Logger, ): Promise { - const model = cfg.model ?? "text-embedding-004"; + const model = cfg.model ?? "gemini-embedding-001"; const endpoint = cfg.endpoint ?? `https://generativelanguage.googleapis.com/v1beta/models/${model}:batchEmbedContents`; diff --git a/apps/memos-local-openclaw/src/viewer/html.ts b/apps/memos-local-openclaw/src/viewer/html.ts index 8c48f7017..d091e06cd 100644 --- a/apps/memos-local-openclaw/src/viewer/html.ts +++ b/apps/memos-local-openclaw/src/viewer/html.ts @@ -7234,7 +7234,7 @@ var _providerDefaults={ cohere:{endpoint:'https://api.cohere.com/v2',embModel:'embed-english-v3.0'}, mistral:{endpoint:'https://api.mistral.ai/v1',embModel:'mistral-embed'}, voyage:{endpoint:'https://api.voyageai.com/v1',embModel:'voyage-3'}, - gemini:{endpoint:'',embModel:'text-embedding-004',chatModel:'gemini-2.0-flash'}, + gemini:{endpoint:'',embModel:'gemini-embedding-001',chatModel:'gemini-2.0-flash'}, zhipu:{endpoint:'https://open.bigmodel.cn/api/paas/v4',embModel:'embedding-3',chatModel:'glm-4-flash'}, deepseek:{endpoint:'https://api.deepseek.com/v1',chatModel:'deepseek-chat'}, bailian:{endpoint:'https://coding.dashscope.aliyuncs.com/v1',embModel:'text-embedding-v3',chatModel:'qwen-max'}, diff --git a/apps/memos-local-openclaw/src/viewer/server.ts b/apps/memos-local-openclaw/src/viewer/server.ts index e3474cc70..6d215f70e 100644 --- a/apps/memos-local-openclaw/src/viewer/server.ts +++ b/apps/memos-local-openclaw/src/viewer/server.ts @@ -3874,11 +3874,22 @@ export class ViewerServer { return vecs[0].length; } if (provider === "gemini") { - const url = `https://generativelanguage.googleapis.com/v1/models/${model || "text-embedding-004"}:embedContent?key=${apiKey}`; + const geminiModel = model || "gemini-embedding-001"; + const geminiEndpoint = ( + endpoint || + `https://generativelanguage.googleapis.com/v1beta/models/${geminiModel}:batchEmbedContents` + ).replace(/\/+$/, ""); + const separator = geminiEndpoint.includes("?") ? "&" : "?"; + const url = `${geminiEndpoint}${separator}key=${apiKey}`; const resp = await fetch(url, { method: "POST", headers: { "Content-Type": "application/json" }, - body: JSON.stringify({ content: { parts: [{ text: "test embedding vector" }] } }), + body: JSON.stringify({ + requests: [{ + model: `models/${geminiModel}`, + content: { parts: [{ text: "test embedding vector" }] }, + }], + }), signal: AbortSignal.timeout(15_000), }); if (!resp.ok) { @@ -3886,7 +3897,7 @@ export class ViewerServer { throw new Error(`Gemini embed ${resp.status}: ${txt}`); } const json = await resp.json() as any; - const vec = json?.embedding?.values; + const vec = json?.embeddings?.[0]?.values; if (!Array.isArray(vec) || vec.length === 0) { throw new Error("Gemini returned empty embedding vector"); } diff --git a/apps/memos-local-openclaw/tests/gemini-viewer-test.test.ts b/apps/memos-local-openclaw/tests/gemini-viewer-test.test.ts new file mode 100644 index 000000000..8240c9cc3 --- /dev/null +++ b/apps/memos-local-openclaw/tests/gemini-viewer-test.test.ts @@ -0,0 +1,24 @@ +import { describe, expect, it } from "vitest"; +import fs from "node:fs"; +import path from "node:path"; + +const root = process.cwd(); + +describe("Gemini viewer embedding test", () => { + it("uses the batch embedding API and current default model", () => { + const server = fs.readFileSync(path.join(root, "src/viewer/server.ts"), "utf-8"); + const provider = fs.readFileSync( + path.join(root, "src/embedding/providers/gemini.ts"), + "utf-8", + ); + const html = fs.readFileSync(path.join(root, "src/viewer/html.ts"), "utf-8"); + + expect(server).toContain("v1beta/models/${geminiModel}:batchEmbedContents"); + expect(server).toContain("const geminiEndpoint = ("); + expect(server).toContain("requests: [{"); + expect(server).toContain("json?.embeddings?.[0]?.values"); + expect(server).not.toContain(":embedContent?key=${apiKey}"); + expect(provider).toContain('cfg.model ?? "gemini-embedding-001"'); + expect(html).toContain("embModel:'gemini-embedding-001'"); + }); +}); From 65b814dbe636c162a46f37bdf7cc7fd781225d5e Mon Sep 17 00:00:00 2001 From: Ziyang Guo <121015044+RunMarshal@users.noreply.github.com> Date: Wed, 8 Jul 2026 21:43:10 +0800 Subject: [PATCH 4/4] fix(openclaw): don't leak Gemini API key to user-supplied endpoints OCR review on #2050 surfaced a security regression: the viewer Gemini embedding probe appended ?key= to every URL, including URLs the caller built themselves. This silently sent the user's Gemini API key to a third-party server whenever a custom 'endpoint' was configured. - When 'endpoint' is supplied, build the URL without any key parameter. - When 'endpoint' is supplied, omit the hardcoded 'models/' field so a proxy can route on its own model identifier. Adds a regression test that asserts both branches. --- apps/memos-local-openclaw/src/viewer/server.ts | 13 +++++++++++-- .../tests/gemini-viewer-test.test.ts | 10 ++++++++++ 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/apps/memos-local-openclaw/src/viewer/server.ts b/apps/memos-local-openclaw/src/viewer/server.ts index 6d215f70e..6ee8184fe 100644 --- a/apps/memos-local-openclaw/src/viewer/server.ts +++ b/apps/memos-local-openclaw/src/viewer/server.ts @@ -3880,13 +3880,22 @@ export class ViewerServer { `https://generativelanguage.googleapis.com/v1beta/models/${geminiModel}:batchEmbedContents` ).replace(/\/+$/, ""); const separator = geminiEndpoint.includes("?") ? "&" : "?"; - const url = `${geminiEndpoint}${separator}key=${apiKey}`; + // Only append the API key for the default Gemini endpoint; for custom + // endpoints the caller is responsible for authentication and we must + // never leak the Gemini API key to a user-controlled server. + const url = endpoint + ? geminiEndpoint + : `${geminiEndpoint}${separator}key=${apiKey}`; + // When the caller supplies a custom endpoint, don't hardcode the + // default model name in the request body either — the proxy may + // route based on this field. + const bodyModel = endpoint ? undefined : `models/${geminiModel}`; const resp = await fetch(url, { method: "POST", headers: { "Content-Type": "application/json" }, body: JSON.stringify({ requests: [{ - model: `models/${geminiModel}`, + ...(bodyModel ? { model: bodyModel } : {}), content: { parts: [{ text: "test embedding vector" }] }, }], }), diff --git a/apps/memos-local-openclaw/tests/gemini-viewer-test.test.ts b/apps/memos-local-openclaw/tests/gemini-viewer-test.test.ts index 8240c9cc3..d87340989 100644 --- a/apps/memos-local-openclaw/tests/gemini-viewer-test.test.ts +++ b/apps/memos-local-openclaw/tests/gemini-viewer-test.test.ts @@ -21,4 +21,14 @@ describe("Gemini viewer embedding test", () => { expect(provider).toContain('cfg.model ?? "gemini-embedding-001"'); expect(html).toContain("embModel:'gemini-embedding-001'"); }); + + it("does not append the Gemini API key when a custom endpoint is supplied", () => { + const server = fs.readFileSync(path.join(root, "src/viewer/server.ts"), "utf-8"); + // The url-construction block must branch on `endpoint` so that user- + // supplied endpoints never receive ?key=. + expect(server).toMatch(/const url = endpoint\s*\?\s*geminiEndpoint\s*:/); + // And the model field must be omitted (or fall back to undefined) when + // a custom endpoint is supplied, so a proxy can route correctly. + expect(server).toMatch(/const bodyModel = endpoint\s*\?\s*undefined\s*:/); + }); });