From 2161b4afbe5c62a42777b6e9e325c4f0efac7deb Mon Sep 17 00:00:00 2001 From: ellamartirosyan Date: Tue, 3 Nov 2026 14:32:11 +0200 Subject: [PATCH 1/2] fix: re-export domain specific enums --- src/enums/common/metadata/linkType.ts | 4 ++++ src/enums/common/metadata/protocolType.ts | 4 ++++ src/enums/common/metadata/sourceType.ts | 14 ++++++++------ tests/unit/linkType.spec.ts | 4 ---- 4 files changed, 16 insertions(+), 10 deletions(-) diff --git a/src/enums/common/metadata/linkType.ts b/src/enums/common/metadata/linkType.ts index 112a988..52a6364 100644 --- a/src/enums/common/metadata/linkType.ts +++ b/src/enums/common/metadata/linkType.ts @@ -1 +1,5 @@ export * from './linkType/common'; +export * from './linkType/RasterLinkType'; +export * from './linkType/ThreeDLinkType'; +export * from './linkType/DemLinkType'; +export * from './linkType/VectorLinkType'; diff --git a/src/enums/common/metadata/protocolType.ts b/src/enums/common/metadata/protocolType.ts index c7ca6c0..82201b5 100644 --- a/src/enums/common/metadata/protocolType.ts +++ b/src/enums/common/metadata/protocolType.ts @@ -28,3 +28,7 @@ export type ProtocolType = | import('./protocolType/common').PROPRIETARY_DemProtocolType; export * from './protocolType/common'; +export * from './protocolType/RasterProtocolType'; +export * from './protocolType/ThreeDProtocolType'; +export * from './protocolType/DemProtocolType'; +export * from './protocolType/VectorProtocolType'; diff --git a/src/enums/common/metadata/sourceType.ts b/src/enums/common/metadata/sourceType.ts index 9ba37c4..8077c1a 100644 --- a/src/enums/common/metadata/sourceType.ts +++ b/src/enums/common/metadata/sourceType.ts @@ -1,6 +1,8 @@ -export enum SourceType { - EXTERNAL = 'EXTERNAL', - RASTER_RESOURCE = 'RASTER_RESOURCE', - RESOLVED_RASTER_RESOURCE = 'RESOLVED_RASTER_RESOURCE', - UNRESOLVED_RASTER_RESOURCE = 'UNRESOLVED_RASTER_RESOURCE', -} +/* eslint-disable @typescript-eslint/naming-convention */ +export const SourceType = { + RASTER_RESOURCE: 'RASTER_RESOURCE', + EXTERNAL: 'EXTERNAL', +} as const; + +export type SourceType = (typeof SourceType)[keyof typeof SourceType]; +/* eslint-enable @typescript-eslint/naming-convention */ diff --git a/tests/unit/linkType.spec.ts b/tests/unit/linkType.spec.ts index 1691167..6a11ea3 100644 --- a/tests/unit/linkType.spec.ts +++ b/tests/unit/linkType.spec.ts @@ -37,8 +37,4 @@ describe('linkType', () => { it('rejects a value that belongs to none of the exported enums', () => { expect(Object.values(AssetLinkType)).not.toContain('NOT_A_REAL_LINK_TYPE'); }); - - it('no longer re-exports the domain-specific link enums (moved to mc-models)', () => { - expect(sorted(Object.keys(linkTypeModule))).toEqual(sorted(['ThumbnailLinkType', 'LegendLinkType', 'AssetLinkType'])); - }); }); From bbfdc4f62c1cb8e634b59fbac389270c0d74ed54 Mon Sep 17 00:00:00 2001 From: ellamartirosyan Date: Tue, 3 Nov 2026 14:36:29 +0200 Subject: [PATCH 2/2] fix: code review --- src/enums/common/metadata/sourceType.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/enums/common/metadata/sourceType.ts b/src/enums/common/metadata/sourceType.ts index 8077c1a..bb03c1c 100644 --- a/src/enums/common/metadata/sourceType.ts +++ b/src/enums/common/metadata/sourceType.ts @@ -1,6 +1,6 @@ /* eslint-disable @typescript-eslint/naming-convention */ export const SourceType = { - RASTER_RESOURCE: 'RASTER_RESOURCE', + RASTER_RESOURCE: 'CATALOG_RESOURCE', EXTERNAL: 'EXTERNAL', } as const;