From 8fc9abe8337eb30aeb59150cafcaccde97d2b2ce Mon Sep 17 00:00:00 2001 From: "John L. Villalovos" Date: Wed, 18 Nov 2026 19:09:10 -0800 Subject: [PATCH] refactor(config): name the GetKey parameter the same everywhere IConfigurationFile::GetKey() called its first parameter $name, while Configuration, ConfigurationFile and the test fakes call it $configDef. A named argument is matched against the method that actually runs. GetKey(configDef: ...) therefore works on the concrete classes but throws "Unknown named parameter" on anything that implements the interface with the interface's own name, such as a PHPUnit mock of IConfiguration. Rename the interface parameter to $configDef, so the name is stable and calls can use named arguments as AGENTS.md asks. No caller passes the argument by the old name. Assisted-by: Claude:claude-fable-5-2 --- lib/Config/Configuration.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Config/Configuration.php b/lib/Config/Configuration.php index 3db34dab92..7cf8ba963a 100644 --- a/lib/Config/Configuration.php +++ b/lib/Config/Configuration.php @@ -26,11 +26,11 @@ public function File(string $configId): ConfigurationFile; interface IConfigurationFile { /** - * @param ConfigKey|array $name a ConfigKeys definition + * @param ConfigKey|array $configDef a ConfigKeys definition * @param null|IConvert $converter * @return mixed|string */ - public function GetKey($name, $converter = null); + public function GetKey($configDef, $converter = null); /** * @return string the full url to the root of this LibreBooking instance WITHOUT the trailing /