From 1a688b963de1e6f856f7bda6b55a4d6ae2c94e21 Mon Sep 17 00:00:00 2001 From: Astrid Gealer Date: Wed, 28 Oct 2026 22:55:30 +0000 Subject: [PATCH 1/2] docs(iac): describe the fire sweep as carrying out delayed human approvals The enable_fire_scheduled_purchases_schedule descriptions, the CHANGELOG entry and the Lambda module comment said the sweep runs "delayed auto-approved purchases". A row reaches status=scheduled only through approveWithDelay, when a person approves while purchase_delay_hours > 0 (48 by default), so on a default install this sweep is what executes every approval. An operator reading "auto-approved" could switch it off and leave every approval unexecuted. The CHANGELOG entry also claimed GKE gets the sweep, but GKE deployed from terraform/environments/gcp gets no Cloud Scheduler jobs. Text only: no variable default, resource or schedule changes. Refs #712 Co-Authored-By: Claude Opus 5.5 --- CHANGELOG.md | 10 +++++++--- terraform/environments/aws/variables.tf | 2 +- terraform/environments/azure/variables.tf | 2 +- terraform/environments/gcp/variables.tf | 2 +- terraform/modules/compute/aws/fargate/variables.tf | 2 +- terraform/modules/compute/aws/lambda/main.tf | 6 +++--- terraform/modules/compute/aws/lambda/variables.tf | 2 +- terraform/modules/compute/azure/aks/variables.tf | 2 +- .../modules/compute/azure/container-apps/variables.tf | 2 +- terraform/modules/compute/gcp/cloud-run/variables.tf | 2 +- terraform/modules/compute/gcp/gke/variables.tf | 2 +- 11 files changed, 19 insertions(+), 15 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d3a8ebe2d..5f3c55dec 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -54,9 +54,13 @@ are the full record until the next release. - **The fire_scheduled_purchases sweep is now on by default on every Terraform platform** (Lambda, Fargate, Cloud Run, GKE, Container Apps and - AKS), every 15 minutes. It executes delayed auto-approved purchases once - their scheduled time passes; until now they never ran unless the operator - turned the sweep on. The server refuses (and sends the purchase-failed + AKS), every 15 minutes. It carries out every purchase a person approves + while a purchase delay is set (`purchase_delay_hours`, 48 by default) once + the delay ends; until now those approvals never executed unless the + operator turned the sweep on. Keep it on unless `purchase_delay_hours` is + 0. GKE deployed from `terraform/environments/gcp` still gets no Cloud + Scheduler jobs, this one included (that environment doesn't pass + `enable_scheduled_tasks` to GKE). The server refuses (and sends the purchase-failed alert for) any purchase due more than 24h ago, so the first run cannot buy a stale backlog. Set `enable_fire_scheduled_purchases_schedule = false` to opt out. The process_scheduled_purchases sweep stays opt-in (#712) diff --git a/terraform/environments/aws/variables.tf b/terraform/environments/aws/variables.tf index b16ded680..0e4f64f0a 100644 --- a/terraform/environments/aws/variables.tf +++ b/terraform/environments/aws/variables.tf @@ -395,7 +395,7 @@ variable "ladder_run_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which executes delayed auto-approved purchases once their scheduled time has passed. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/environments/azure/variables.tf b/terraform/environments/azure/variables.tf index 477f9f3d1..0dbfde232 100644 --- a/terraform/environments/azure/variables.tf +++ b/terraform/environments/azure/variables.tf @@ -444,7 +444,7 @@ variable "analytics_collect_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which executes delayed auto-approved purchases once their scheduled time has passed. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/environments/gcp/variables.tf b/terraform/environments/gcp/variables.tf index 06034bbbe..394032a75 100644 --- a/terraform/environments/gcp/variables.tf +++ b/terraform/environments/gcp/variables.tf @@ -370,7 +370,7 @@ variable "analytics_collect_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which executes delayed auto-approved purchases once their scheduled time has passed. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/modules/compute/aws/fargate/variables.tf b/terraform/modules/compute/aws/fargate/variables.tf index 55744b93e..a0f550cf3 100644 --- a/terraform/modules/compute/aws/fargate/variables.tf +++ b/terraform/modules/compute/aws/fargate/variables.tf @@ -226,7 +226,7 @@ variable "ladder_run_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which executes delayed auto-approved purchases once their scheduled time has passed. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/modules/compute/aws/lambda/main.tf b/terraform/modules/compute/aws/lambda/main.tf index 91968553c..1a4515f98 100644 --- a/terraform/modules/compute/aws/lambda/main.tf +++ b/terraform/modules/compute/aws/lambda/main.tf @@ -775,9 +775,9 @@ resource "aws_lambda_permission" "eventbridge_ladder_run" { # Frequent tick that invokes the fire_scheduled_purchases task: # scans purchase_executions in status=scheduled whose # scheduled_execution_at is in the past and fires each one. This -# sweep is the runtime mechanism that makes auto-approve delayed -# purchases actually execute; without it, scheduled tranches would -# never fire between daily ladder runs. On by default (owner decision +# sweep is what carries out a purchase a person approved while a +# purchase delay is set (purchase_delay_hours, 48 by default); without +# it those approvals never execute. On by default (owner decision # for #712): the server refuses any row due more than 24h ago (#1549), # so a first tick after enabling cannot buy a stale backlog. diff --git a/terraform/modules/compute/aws/lambda/variables.tf b/terraform/modules/compute/aws/lambda/variables.tf index 770799b30..9ec7123e8 100644 --- a/terraform/modules/compute/aws/lambda/variables.tf +++ b/terraform/modules/compute/aws/lambda/variables.tf @@ -246,7 +246,7 @@ variable "ladder_run_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which executes delayed auto-approved purchases once their scheduled time has passed. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/modules/compute/azure/aks/variables.tf b/terraform/modules/compute/azure/aks/variables.tf index c29cafd29..5b12d643b 100644 --- a/terraform/modules/compute/azure/aks/variables.tf +++ b/terraform/modules/compute/azure/aks/variables.tf @@ -277,7 +277,7 @@ variable "analytics_collect_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which executes delayed auto-approved purchases once their scheduled time has passed. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/modules/compute/azure/container-apps/variables.tf b/terraform/modules/compute/azure/container-apps/variables.tf index c16bc6dc7..d6a9ea5e2 100644 --- a/terraform/modules/compute/azure/container-apps/variables.tf +++ b/terraform/modules/compute/azure/container-apps/variables.tf @@ -285,7 +285,7 @@ variable "analytics_collect_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which executes delayed auto-approved purchases once their scheduled time has passed. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/modules/compute/gcp/cloud-run/variables.tf b/terraform/modules/compute/gcp/cloud-run/variables.tf index defe61990..f518c40bf 100644 --- a/terraform/modules/compute/gcp/cloud-run/variables.tf +++ b/terraform/modules/compute/gcp/cloud-run/variables.tf @@ -216,7 +216,7 @@ variable "analytics_collect_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which executes delayed auto-approved purchases once their scheduled time has passed. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/modules/compute/gcp/gke/variables.tf b/terraform/modules/compute/gcp/gke/variables.tf index 0d1cea345..e8bd44d26 100644 --- a/terraform/modules/compute/gcp/gke/variables.tf +++ b/terraform/modules/compute/gcp/gke/variables.tf @@ -306,7 +306,7 @@ variable "analytics_collect_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which executes delayed auto-approved purchases once their scheduled time has passed. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } From e208db6b6a226deec3de9a8650b489926ab96b8e Mon Sep 17 00:00:00 2001 From: Astrid Gealer Date: Wed, 28 Oct 2026 23:00:08 +0000 Subject: [PATCH 2/2] docs(iac): purchase_delay_hours defaults to 0, and a stopped sweep never alerts Review of the previous commit: migration 000070 adds purchase_delay_hours with DEFAULT 0, so every migrated install executes approvals immediately. config.DefaultPurchaseDelayHours (48) only applies when no settings row exists. With the fire sweep off, delayed approvals stay scheduled with no alert; the 24h age cap only refuses them on the next sweep run. Refs #712 Co-Authored-By: Claude Opus 5.5 --- CHANGELOG.md | 8 ++++---- terraform/environments/aws/variables.tf | 2 +- terraform/environments/azure/variables.tf | 2 +- terraform/environments/gcp/variables.tf | 2 +- terraform/modules/compute/aws/fargate/variables.tf | 2 +- terraform/modules/compute/aws/lambda/main.tf | 4 ++-- terraform/modules/compute/aws/lambda/variables.tf | 2 +- terraform/modules/compute/azure/aks/variables.tf | 2 +- .../modules/compute/azure/container-apps/variables.tf | 2 +- terraform/modules/compute/gcp/cloud-run/variables.tf | 2 +- terraform/modules/compute/gcp/gke/variables.tf | 2 +- 11 files changed, 15 insertions(+), 15 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5f3c55dec..2481f2284 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -55,10 +55,10 @@ are the full record until the next release. - **The fire_scheduled_purchases sweep is now on by default on every Terraform platform** (Lambda, Fargate, Cloud Run, GKE, Container Apps and AKS), every 15 minutes. It carries out every purchase a person approves - while a purchase delay is set (`purchase_delay_hours`, 48 by default) once - the delay ends; until now those approvals never executed unless the - operator turned the sweep on. Keep it on unless `purchase_delay_hours` is - 0. GKE deployed from `terraform/environments/gcp` still gets no Cloud + while a purchase delay is set (`purchase_delay_hours` > 0; the migrated + default is 0, which executes approvals immediately) once the delay ends; + until now those approvals never executed unless the operator turned the + sweep on. Keep it on unless `purchase_delay_hours` stays 0. GKE deployed from `terraform/environments/gcp` still gets no Cloud Scheduler jobs, this one included (that environment doesn't pass `enable_scheduled_tasks` to GKE). The server refuses (and sends the purchase-failed alert for) any purchase due more than 24h ago, so the first run cannot buy diff --git a/terraform/environments/aws/variables.tf b/terraform/environments/aws/variables.tf index 0e4f64f0a..ed893f19f 100644 --- a/terraform/environments/aws/variables.tf +++ b/terraform/environments/aws/variables.tf @@ -395,7 +395,7 @@ variable "ladder_run_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours > 0; the migrated default is 0, which executes approvals immediately) once the delay ends. With the sweep off, those approved purchases stay scheduled and never execute, with no alert, so turn it off only where purchase_delay_hours stays 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/environments/azure/variables.tf b/terraform/environments/azure/variables.tf index 0dbfde232..6f729e7e0 100644 --- a/terraform/environments/azure/variables.tf +++ b/terraform/environments/azure/variables.tf @@ -444,7 +444,7 @@ variable "analytics_collect_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours > 0; the migrated default is 0, which executes approvals immediately) once the delay ends. With the sweep off, those approved purchases stay scheduled and never execute, with no alert, so turn it off only where purchase_delay_hours stays 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/environments/gcp/variables.tf b/terraform/environments/gcp/variables.tf index 394032a75..8b24101fa 100644 --- a/terraform/environments/gcp/variables.tf +++ b/terraform/environments/gcp/variables.tf @@ -370,7 +370,7 @@ variable "analytics_collect_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours > 0; the migrated default is 0, which executes approvals immediately) once the delay ends. With the sweep off, those approved purchases stay scheduled and never execute, with no alert, so turn it off only where purchase_delay_hours stays 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/modules/compute/aws/fargate/variables.tf b/terraform/modules/compute/aws/fargate/variables.tf index a0f550cf3..dcb4cd9ce 100644 --- a/terraform/modules/compute/aws/fargate/variables.tf +++ b/terraform/modules/compute/aws/fargate/variables.tf @@ -226,7 +226,7 @@ variable "ladder_run_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours > 0; the migrated default is 0, which executes approvals immediately) once the delay ends. With the sweep off, those approved purchases stay scheduled and never execute, with no alert, so turn it off only where purchase_delay_hours stays 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/modules/compute/aws/lambda/main.tf b/terraform/modules/compute/aws/lambda/main.tf index 1a4515f98..14d0ea71a 100644 --- a/terraform/modules/compute/aws/lambda/main.tf +++ b/terraform/modules/compute/aws/lambda/main.tf @@ -776,8 +776,8 @@ resource "aws_lambda_permission" "eventbridge_ladder_run" { # scans purchase_executions in status=scheduled whose # scheduled_execution_at is in the past and fires each one. This # sweep is what carries out a purchase a person approved while a -# purchase delay is set (purchase_delay_hours, 48 by default); without -# it those approvals never execute. On by default (owner decision +# purchase delay is set (purchase_delay_hours > 0); without it those +# approvals never execute. On by default (owner decision # for #712): the server refuses any row due more than 24h ago (#1549), # so a first tick after enabling cannot buy a stale backlog. diff --git a/terraform/modules/compute/aws/lambda/variables.tf b/terraform/modules/compute/aws/lambda/variables.tf index 9ec7123e8..3d928f848 100644 --- a/terraform/modules/compute/aws/lambda/variables.tf +++ b/terraform/modules/compute/aws/lambda/variables.tf @@ -246,7 +246,7 @@ variable "ladder_run_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours > 0; the migrated default is 0, which executes approvals immediately) once the delay ends. With the sweep off, those approved purchases stay scheduled and never execute, with no alert, so turn it off only where purchase_delay_hours stays 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/modules/compute/azure/aks/variables.tf b/terraform/modules/compute/azure/aks/variables.tf index 5b12d643b..19494d338 100644 --- a/terraform/modules/compute/azure/aks/variables.tf +++ b/terraform/modules/compute/azure/aks/variables.tf @@ -277,7 +277,7 @@ variable "analytics_collect_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours > 0; the migrated default is 0, which executes approvals immediately) once the delay ends. With the sweep off, those approved purchases stay scheduled and never execute, with no alert, so turn it off only where purchase_delay_hours stays 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/modules/compute/azure/container-apps/variables.tf b/terraform/modules/compute/azure/container-apps/variables.tf index d6a9ea5e2..8953d4e41 100644 --- a/terraform/modules/compute/azure/container-apps/variables.tf +++ b/terraform/modules/compute/azure/container-apps/variables.tf @@ -285,7 +285,7 @@ variable "analytics_collect_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours > 0; the migrated default is 0, which executes approvals immediately) once the delay ends. With the sweep off, those approved purchases stay scheduled and never execute, with no alert, so turn it off only where purchase_delay_hours stays 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/modules/compute/gcp/cloud-run/variables.tf b/terraform/modules/compute/gcp/cloud-run/variables.tf index f518c40bf..b3bcb71d9 100644 --- a/terraform/modules/compute/gcp/cloud-run/variables.tf +++ b/terraform/modules/compute/gcp/cloud-run/variables.tf @@ -216,7 +216,7 @@ variable "analytics_collect_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours > 0; the migrated default is 0, which executes approvals immediately) once the delay ends. With the sweep off, those approved purchases stay scheduled and never execute, with no alert, so turn it off only where purchase_delay_hours stays 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true } diff --git a/terraform/modules/compute/gcp/gke/variables.tf b/terraform/modules/compute/gcp/gke/variables.tf index e8bd44d26..01a9766a0 100644 --- a/terraform/modules/compute/gcp/gke/variables.tf +++ b/terraform/modules/compute/gcp/gke/variables.tf @@ -306,7 +306,7 @@ variable "analytics_collect_schedule" { } variable "enable_fire_scheduled_purchases_schedule" { - description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours, 48 by default) once the delay ends. With the sweep off, those approved purchases never execute and are refused 24h after they fall due, so turn it off only where purchase_delay_hours is 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." + description = "Schedule the fire_scheduled_purchases sweep, which carries out every purchase a person approves while a purchase delay is set (purchase_delay_hours > 0; the migrated default is 0, which executes approvals immediately) once the delay ends. With the sweep off, those approved purchases stay scheduled and never execute, with no alert, so turn it off only where purchase_delay_hours stays 0. On by default: the server refuses, and alerts on, any purchase due more than 24h ago (SCHEDULED_PURCHASE_MAX_OVERDUE, #1549), so turning it on cannot buy a stale backlog. Set false to opt out." type = bool default = true }