From 363e36b07f80a9eab0546e10e703a9cc57b5d837 Mon Sep 17 00:00:00 2001 From: ArnoKeesmand Date: Sat, 11 Jul 2026 14:56:00 +0200 Subject: [PATCH 1/2] bump mc version to stable to simplify testing --- gradle.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gradle.properties b/gradle.properties index aee28e4a..4c403032 100644 --- a/gradle.properties +++ b/gradle.properties @@ -3,7 +3,7 @@ org.gradle.jvmargs=-Xmx2048M # Fabric Properties # check these on https://fabricmc.net/develop -minecraft_version=26.2-rc-2 +minecraft_version=26.2 loader_version=0.18.3 loom_version=1.17-SNAPSHOT From 8aabb7356f1846e864222923ac5fa7a24bce84c0 Mon Sep 17 00:00:00 2001 From: ArnoKeesmand Date: Sat, 11 Jul 2026 15:22:35 +0200 Subject: [PATCH 2/2] fix list command translations --- .../fibermc/essentialcommands/EssentialCommandRegistry.java | 4 ++-- .../essentialcommands/commands/ListCommandFactory.java | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/fibermc/essentialcommands/EssentialCommandRegistry.java b/src/main/java/com/fibermc/essentialcommands/EssentialCommandRegistry.java index 4891a288..9ba2d93d 100644 --- a/src/main/java/com/fibermc/essentialcommands/EssentialCommandRegistry.java +++ b/src/main/java/com/fibermc/essentialcommands/EssentialCommandRegistry.java @@ -168,7 +168,7 @@ public static void register( homeListBuilder .requires(ECPerms.require(ECPerms.Registry.home_tp, 0)) .executes(ListCommandFactory.create( - ECText.getInstance().getString("cmd.home.list.start"), + "cmd.home.list.start", "home tp", HomeCommand.Suggestion::getSuggestionEntries)); @@ -255,7 +255,7 @@ public static void register( warpListBuilder .requires(ECPerms.require(ECPerms.Registry.warp_tp, 0)) .executes(ListCommandFactory.create( - ECText.getInstance().getString("cmd.warp.list.start"), + "cmd.warp.list.start", "warp tp", (context) -> ManagerLocator.getInstance().getWorldDataManager().getAccessibleWarps(context.getSource().getPlayerOrException()).toList(), NamedMinecraftLocation::getName diff --git a/src/main/java/com/fibermc/essentialcommands/commands/ListCommandFactory.java b/src/main/java/com/fibermc/essentialcommands/commands/ListCommandFactory.java index 44b77e10..0fb47da4 100644 --- a/src/main/java/com/fibermc/essentialcommands/commands/ListCommandFactory.java +++ b/src/main/java/com/fibermc/essentialcommands/commands/ListCommandFactory.java @@ -29,11 +29,12 @@ private ListCommandFactory() {} // Specify leading response text, and supplier of list of strings/Text public static Command create( - String responsePreText, + String translationKey, String commandExecText, SuggestionListProvider> suggestionsProvider) { return (CommandContext context) -> { + String responsePreText = ECText.getInstance().getString(translationKey); var styleProvider = PlayerProfile.accessFromContextOrThrow(context); Collection> suggestionsList = suggestionsProvider.getSuggestionList(context); @@ -46,12 +47,13 @@ public static Command create( } public static Command create( - String responsePreText, + String translationKey, String commandExecText, SuggestionListProvider suggestionsProvider, Function nameAccessor) { return (CommandContext context) -> { + String responsePreText = ECText.getInstance().getString(translationKey); var styleProvider = PlayerProfile.accessFromContextOrThrow(context); Collection suggestionsList = suggestionsProvider.getSuggestionList(context);