From 900fcfbf803918df27de9ba2fdc1c55c0144b50f Mon Sep 17 00:00:00 2001 From: martgil Date: Fri, 19 Jun 2026 18:30:47 +0800 Subject: [PATCH 1/3] fix: correctly deletes expired keys --- extension/js/common/core/expiration-cache.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extension/js/common/core/expiration-cache.ts b/extension/js/common/core/expiration-cache.ts index c114b8ddb36..17cfc61c120 100644 --- a/extension/js/common/core/expiration-cache.ts +++ b/extension/js/common/core/expiration-cache.ts @@ -84,8 +84,8 @@ export class ExpirationCache { keysToDelete.push(key); } } - for (const key of keysToDelete) { - await this.set(key); + if (keysToDelete.length) { + await storageRemove('session', keysToDelete); } }; From 846cb07aa38c4908d3da903082c48b7ce785d44b Mon Sep 17 00:00:00 2001 From: martgil Date: Fri, 19 Jun 2026 18:31:44 +0800 Subject: [PATCH 2/3] fix: eslint error --- extension/js/common/settings.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/extension/js/common/settings.ts b/extension/js/common/settings.ts index 2a4a5744f5d..d8f77758d37 100644 --- a/extension/js/common/settings.ts +++ b/extension/js/common/settings.ts @@ -44,7 +44,8 @@ export class Settings { userInputs: PgpPwd.weakWords(), }, }; - const zxcvbn = new zxcvbnts.core.ZxcvbnFactory(options); + // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment + const zxcvbn = new zxcvbnts.core.ZxcvbnFactory(options) as { check(passphrase: string): { guesses: number } }; const guesses = zxcvbn.check(passphrase).guesses; return PgpPwd.estimateStrength(guesses, type); } From fc6092c865cc9be9ab7f7a71e2b62df84bc847ad Mon Sep 17 00:00:00 2001 From: martgil Date: Fri, 19 Jun 2026 18:36:03 +0800 Subject: [PATCH 3/3] chore: remove comments --- extension/js/common/settings.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/extension/js/common/settings.ts b/extension/js/common/settings.ts index d8f77758d37..5e726211bae 100644 --- a/extension/js/common/settings.ts +++ b/extension/js/common/settings.ts @@ -44,7 +44,6 @@ export class Settings { userInputs: PgpPwd.weakWords(), }, }; - // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment const zxcvbn = new zxcvbnts.core.ZxcvbnFactory(options) as { check(passphrase: string): { guesses: number } }; const guesses = zxcvbn.check(passphrase).guesses; return PgpPwd.estimateStrength(guesses, type);