You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
test_xpay_fake_channeld is marked @pytest.mark.skip(reason="channeld_fakenet needs updating"). A plain skip stays silent once the underlying problem is fixed, so the test will sit disabled indefinitely.
Two things:
Use @pytest.mark.xfail(strict=True) so it fails loudly when it starts passing.
Follow-up from #9150.
test_xpay_fake_channeldis marked@pytest.mark.skip(reason="channeld_fakenet needs updating"). A plainskipstays silent once the underlying problem is fixed, so the test will sit disabled indefinitely.Two things:
@pytest.mark.xfail(strict=True)so it fails loudly when it starts passing.Related: the same PR added an
askrene_age('xpay', 1)call inside the test loop as a workaround for impression buildup, see #9375.