Remove version information from schema filename, remove obsolete features#142
Conversation
mkavulich
requested review from
MarekWlasak,
cacraigucar,
climbfuji,
dustinswales,
gold2718,
grantfirl,
mwaxmonsky,
nusbaume,
peverwhee,
ss421 and
svahl991
as code owners
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
Approving although I'm sorry to see the Python2 go, it helps to confuse the bots :)
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Do you know why only Metadata-standard-names.yaml got updated, but not Metadata-standard-names.md?
|
@climbfuji The |
Ahh thanks, that makes sense. |
mkavulich
force-pushed
the
feature/update_tools
branch
from
b3972a5 to
d060fb6
Compare
## Description In the process of trying to add a new tool to check for redundant CF name elements (see #143), I found that our existing tools suffer from a number of issues: - Several tools were not updated appropriately to deal with nested sections (#98) so they are not properly checking all the names in the dictionary - This meant that there were several redundant standard names that had to be removed - A bad merge at some point re-introduced some non-working code from the framework in tools/write_standard_name_table.py; since doctests are not used in this repository, I removed those tests and the un-exercised logic - Changes in #142 that standardized the spelling of the schema file left a lot of stub logic that should be removed This PR resolves those problems. Also, I took the opportunity to clean up the existing tools: - Make all python scripts pass pylint with a 10/10 score - Removed some old format strings, replacing with f-strings (#118) - Standardized the format of comments and multi-line strings - Standardized how command-line arguments are named and referenced - Removed many unnecessary comments And finally, I added the check for duplicate cfname elements that was the start of this whole process. ## Issues Resolves #144, partially resolves #118
3 participants
Description
Because versioning is handled with GitHub tags, and we do not support multiple schema versions for a given tag, it is confusing and unnecessary to include the version number in the filename of the schema file. Therefore this PR renames
standard_names_v1_0.xsd --> standard_names.xsd, and removes the python tooling needed to resolve the schema filename based on version.
In the process of making these updates, I noticed there is a bunch of logic for very old, unsupported python versions, and some remaining logic related to
kindinformation that was removed in #124. I removed this unnecessary logic.Issues
Resolves #141