From ff67e88ce055dd4433dc643c9df2b49438078a32 Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Tue, 14 Jul 2026 21:09:19 +0000 Subject: [PATCH] Fix: Make disable sidebar open setting check more robust - Store setting value in variable for explicit checking - Use strict equality (=== true) instead of truthy evaluation - This ensures the setting is respected in all cases, including when value might be undefined Addresses ENG-2032 Co-authored-by: Michael Gartner --- apps/roam/src/utils/createDiscourseNode.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/roam/src/utils/createDiscourseNode.ts b/apps/roam/src/utils/createDiscourseNode.ts index ba01147f7..6040179f0 100644 --- a/apps/roam/src/utils/createDiscourseNode.ts +++ b/apps/roam/src/utils/createDiscourseNode.ts @@ -191,7 +191,10 @@ const createDiscourseNode = async ({ text: text, }); const handleOpenInSidebar = (uid: string) => { - if (getPersonalSetting([PERSONAL_KEYS.disableSidebarOpen])) return; + const disableSidebarOpen = getPersonalSetting([ + PERSONAL_KEYS.disableSidebarOpen, + ]); + if (disableSidebarOpen === true) return; void openBlockInSidebar(uid); setTimeout(() => { const sidebarTitle = document.querySelector(