|
| 1 | +"use strict"; |
| 2 | + |
| 3 | +const test = require("node:test"); |
| 4 | +const assert = require("node:assert/strict"); |
| 5 | + |
| 6 | +const { renderIntro } = require("./_agent_intro"); |
| 7 | +const { loadIntroData } = require("./_agent_status"); |
| 8 | + |
| 9 | +function capture() { |
| 10 | + let buf = ""; |
| 11 | + return { write: (s) => { buf += s; }, get: () => buf }; |
| 12 | +} |
| 13 | + |
| 14 | +function intro(opts) { |
| 15 | + const out = capture(); |
| 16 | + renderIntro(out, { useColor: false, ...opts }); |
| 17 | + return out.get(); |
| 18 | +} |
| 19 | + |
| 20 | +// ─── the reported bug ───────────────────────────────────────────────────── |
| 21 | +// |
| 22 | +// After logging in to a second host while the saved default still pointed at a |
| 23 | +// dead one, the agent intro said "No databases connected yet → deepsql |
| 24 | +// connections add" — advising the user to create a connection they already had, |
| 25 | +// and hiding the fact that the CLI was pointed at a server that wasn't running. |
| 26 | +// `deepsql connections list` reported the network error correctly the whole |
| 27 | +// time; only the intro swallowed it. |
| 28 | + |
| 29 | +test("an unreachable server is NOT rendered as an empty account", () => { |
| 30 | + const text = intro({ |
| 31 | + connections: [], |
| 32 | + unreachable: "Network error contacting http://localhost:8082/api/connections: fetch failed", |
| 33 | + baseUrl: "http://localhost:8082", |
| 34 | + }); |
| 35 | + assert.doesNotMatch( |
| 36 | + text, |
| 37 | + /No databases connected yet/, |
| 38 | + "must not tell the user to add a connection when the server was never reached", |
| 39 | + ); |
| 40 | + assert.doesNotMatch(text, /deepsql connections add/); |
| 41 | + assert.match(text, /Could not reach your DeepSQL server/); |
| 42 | + // Name the host — the usual cause is the default pointing somewhere else. |
| 43 | + assert.match(text, /http:\/\/localhost:8082/); |
| 44 | + // And carry the underlying reason rather than inventing a friendlier one. |
| 45 | + assert.match(text, /fetch failed/); |
| 46 | +}); |
| 47 | + |
| 48 | +test("a genuinely empty account still gets the onboarding hint", () => { |
| 49 | + const text = intro({ connections: [], unreachable: null }); |
| 50 | + assert.match(text, /No databases connected yet/); |
| 51 | + assert.match(text, /deepsql connections add/); |
| 52 | + assert.doesNotMatch(text, /Could not reach/); |
| 53 | +}); |
| 54 | + |
| 55 | +test("connections are listed when the server is reachable", () => { |
| 56 | + const text = intro({ |
| 57 | + connections: [ |
| 58 | + { name: "Self-Host Vault Postgres", dbType: "postgres", canManage: true }, |
| 59 | + ], |
| 60 | + unreachable: null, |
| 61 | + }); |
| 62 | + assert.match(text, /Connections \(1\)/); |
| 63 | + assert.match(text, /Self-Host Vault Postgres/); |
| 64 | + assert.doesNotMatch(text, /Could not reach/); |
| 65 | + assert.doesNotMatch(text, /No databases connected yet/); |
| 66 | +}); |
| 67 | + |
| 68 | +test("renderIntro without the new fields behaves as before", () => { |
| 69 | + // Callers that predate `unreachable` must be unaffected. |
| 70 | + const text = intro({ connections: [] }); |
| 71 | + assert.match(text, /No databases connected yet/); |
| 72 | +}); |
| 73 | + |
| 74 | +// ─── loadIntroData: report the failure instead of swallowing it ─────────── |
| 75 | + |
| 76 | +test("loadIntroData reports an unreachable server rather than empty connections", async () => { |
| 77 | + // A session pointed at a port nothing is listening on. No stubbing: this is |
| 78 | + // the real client path, which is what silently returned [] before. |
| 79 | + const session = { baseUrl: "http://127.0.0.1:1", token: "t" }; |
| 80 | + const data = await loadIntroData(session, { timeoutMs: 1500 }); |
| 81 | + assert.deepEqual(data.connections, []); |
| 82 | + assert.ok( |
| 83 | + data.unreachable, |
| 84 | + "a connection-list failure must be reported, not swallowed into an empty list", |
| 85 | + ); |
| 86 | + assert.equal(typeof data.unreachable, "string"); |
| 87 | +}); |
0 commit comments