From 903ca7a879b5f3bd6799f4f6bba3dc38845885a7 Mon Sep 17 00:00:00 2001 From: Jez Barnsley Date: Fri, 24 Jul 2026 10:58:44 +0100 Subject: [PATCH] Removed language param as can be derived from request --- .../pageControllers/SummaryPageController.ts | 1 - .../engine/services/notifyService.test.ts | 17 +++++------------ .../plugins/engine/services/notifyService.ts | 1 - src/server/types.ts | 1 - 4 files changed, 5 insertions(+), 15 deletions(-) diff --git a/src/server/plugins/engine/pageControllers/SummaryPageController.ts b/src/server/plugins/engine/pageControllers/SummaryPageController.ts index 7d79907a4..722ee359c 100644 --- a/src/server/plugins/engine/pageControllers/SummaryPageController.ts +++ b/src/server/plugins/engine/pageControllers/SummaryPageController.ts @@ -481,7 +481,6 @@ export async function submitForm( emailAddress, items, submitResponse, - translator.language, formMetadata ) } catch (err) { diff --git a/src/server/plugins/engine/services/notifyService.test.ts b/src/server/plugins/engine/services/notifyService.test.ts index b4c80e9e3..1a9caf79f 100644 --- a/src/server/plugins/engine/services/notifyService.test.ts +++ b/src/server/plugins/engine/services/notifyService.test.ts @@ -1,6 +1,5 @@ import { type FormMetadata } from '@defra/forms-model' -import { EN_GB } from '~/src/server/constants.js' import { escapeMarkdown } from '~/src/server/plugins/engine/components/helpers/index.js' import { checkFormStatus } from '~/src/server/plugins/engine/helpers.js' import { type FormModel } from '~/src/server/plugins/engine/models/index.js' @@ -73,8 +72,7 @@ describe('notifyService', () => { model, 'test@defra.gov.uk', items, - submitResponse, - EN_GB + submitResponse ) expect(sendNotificationMock).toHaveBeenCalledWith( @@ -110,8 +108,7 @@ describe('notifyService', () => { model, 'test@defra.gov.uk', items, - submitResponse, - EN_GB + submitResponse ) expect(sendNotificationMock).toHaveBeenCalledWith( @@ -149,8 +146,7 @@ describe('notifyService', () => { model, 'test@defra.gov.uk', items, - submitResponse, - EN_GB + submitResponse ) expect(sendNotificationMock).toHaveBeenCalledWith( @@ -197,7 +193,6 @@ describe('notifyService', () => { 'test@defra.gov.uk', items, submitResponse, - EN_GB, formMetadata ) @@ -249,8 +244,7 @@ describe('notifyService', () => { model, 'test@defra.gov.uk', items, - submitResponse, - EN_GB + submitResponse ) expect(getFormatter).toHaveBeenCalledWith('machine', '2') @@ -302,8 +296,7 @@ describe('notifyService', () => { model, 'test@defra.gov.uk', items, - submitResponse, - EN_GB + submitResponse ) ).rejects.toThrow('Notification service unavailable') diff --git a/src/server/plugins/engine/services/notifyService.ts b/src/server/plugins/engine/services/notifyService.ts index a3bbaf06d..e6bd3ee0a 100644 --- a/src/server/plugins/engine/services/notifyService.ts +++ b/src/server/plugins/engine/services/notifyService.ts @@ -28,7 +28,6 @@ export async function submit( emailAddress: string, items: DetailItem[], submitResponse: SubmitResponsePayload, - _language: string, formMetadata?: FormMetadata ) { if (!templateId) { diff --git a/src/server/types.ts b/src/server/types.ts index ace3b0639..02c30599a 100644 --- a/src/server/types.ts +++ b/src/server/types.ts @@ -71,7 +71,6 @@ export interface OutputService { emailAddress: string, items: DetailItem[], submitResponse: SubmitResponsePayload, - language: string, formMetadata?: FormMetadata ) => Promise }