When I have a table with a primary key column that's also increment, it's valid to set it to null on the insert statement. the last insert it will then return the auto increment value, which is the primary key in that case.
As already noticed in #44, the auto increment column doesn't have to be part of the primary key, so the return value of last insert id ironically doesn't necessarily belong to the primary key. However, #44 also broke the case, which one might perceive as more common, that the last insert id may also be the primary key.
So, haveInDatabase(table, ['id' => null, ...]) with id as autoincrement and pk will lead to the id being set to null for cleanup, which results in the row not being removed at teardown.
I have prepared a fix for this case, which hopefully is specific enough to not interfere with other use cases.
When I have a table with a primary key column that's also increment, it's valid to set it to
nullon the insert statement. the last insert it will then return the auto increment value, which is the primary key in that case.As already noticed in #44, the auto increment column doesn't have to be part of the primary key, so the return value of last insert id ironically doesn't necessarily belong to the primary key. However, #44 also broke the case, which one might perceive as more common, that the last insert id may also be the primary key.
So,
haveInDatabase(table, ['id' => null, ...])with id as autoincrement and pk will lead to the id being set tonullfor cleanup, which results in the row not being removed at teardown.I have prepared a fix for this case, which hopefully is specific enough to not interfere with other use cases.