completed jest testing on card game and proper fractions

Author: d-odumosu

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -30,7 +30,6 @@ function assertEquals(actualOutput, targetOutput) {
     );
 }
 
-// TODO: Write tests to cover all cases.
 // What combinations of numerators and denominators should you test?
 
 // Example: 1/2 is a proper fraction

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -3,31 +3,35 @@
 const isProperFraction = require("../implement/2-is-proper-fraction");
 
 
-// Special case: numerator is zero
-test(`should return false when denominator is zero`, () => {
-  expect(isProperFraction(1,2 )).toEqual(true);
-  expect(isProperFraction(2,1)).toEqual(false);
-  expect(isProperFraction(5,5)).toEqual(false);
-  expect(isProperFraction(0,5)).toEqual(true);
-  expect(isProperFraction(5,0)).toEqual(false);
-  expect(isProperFraction(0,0)).toEqual(false);
-  expect(isProperFraction(-1,2)).toEqual(true);
-  expect(isProperFraction(1,-2)).toEqual(false);
-  expect(isProperFraction(-2,-1)).toEqual(true);
-  expect(isProperFraction(-1,-2)).toEqual(false);
-  expect(isProperFraction(0.5,1)).toEqual(true);
-  expect(isProperFraction(1.5,1)).toEqual(false);
-  expect(isProperFraction(Infinity,2)).toEqual(false);
-  expect(isProperFraction(2,Infinity)).toEqual(false);
-  expect(isProperFraction(NaN,2)).toEqual(false)
-  expect(isProperFraction(2,NaN)).toEqual(false);
-  expect(isProperFraction(999999999, 1000000000)).toEqual(true)
-
-
-
-
-
-
-
-
+test("should correctly identify proper fractions", () => {
+  // Whole number fractions
+  expect(isProperFraction(1, 2)).toEqual(true);
+  expect(isProperFraction(2, 1)).toEqual(false);
+  expect(isProperFraction(5, 5)).toEqual(false);
+
+  // Zero
+  expect(isProperFraction(0, 5)).toEqual(true);
+  expect(isProperFraction(5, 0)).toEqual(false);
+  expect(isProperFraction(0, 0)).toEqual(false);
+
+  // Negative numbers
+  expect(isProperFraction(-1, 2)).toEqual(true);
+  expect(isProperFraction(1, -2)).toEqual(false);
+  expect(isProperFraction(-2, -1)).toEqual(true);
+  expect(isProperFraction(-1, -2)).toEqual(false);
+
+  // Decimal numbers
+  expect(isProperFraction(0.5, 1)).toEqual(true);
+  expect(isProperFraction(1.5, 1)).toEqual(false);
+
+  // Infinity
+  expect(isProperFraction(Infinity, 2)).toEqual(false);
+  expect(isProperFraction(2, Infinity)).toEqual(false);
+
+  // NaN
+  expect(isProperFraction(NaN, 2)).toEqual(false);
+  expect(isProperFraction(2, NaN)).toEqual(false);
+
+  // Large numbers
+  expect(isProperFraction(999999999, 1000000000)).toEqual(true);
 });

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -2,17 +2,42 @@
 // We will use the same function, but write tests for it using Jest in this file.
 const getCardValue = require("../implement/3-get-card-value");
 
-// TODO: Write tests in Jest syntax to cover all possible outcomes.
 
 // Case 1: Ace (A)
 test(`Should return 11 when given an ace card`, () => {
   expect(getCardValue("A♠")).toEqual(11);
 });
 
-// Suggestion: Group the remaining test data into these categories:
+// Suggestion: Group the remaining test data into these categories: //   ♠ ♥ ♦ ♣
 //   Number Cards (2-10)
+test(`Should return the card's numeric rank for cards 2 through 10`, () =>{
+  expect(getCardValue("2♠")).toEqual(2);
+  expect(getCardValue("3♥")).toEqual(3);
+  expect(getCardValue("4♦")).toEqual(4);
+  expect(getCardValue("5♣")).toEqual(5);
+  expect(getCardValue("6♠")).toEqual(6);
+  expect(getCardValue("7♥")).toEqual(7);
+  expect(getCardValue("8♦")).toEqual(8);
+  expect(getCardValue("9♣")).toEqual(9);
+  expect(getCardValue("10♠")).toEqual(10);
+
+})
 //   Face Cards (J, Q, K)
+test(`should return 10 When the card is a face card ("J", "Q", "K")`, () => {
+  expect(getCardValue("j♠")).toEqual(10);
+  expect(getCardValue("k♦")).toEqual(10);
+  expect(getCardValue("q♣")).toEqual(10);
+
+})
 //   Invalid Cards
+test("should throw an error when an invalid card is played", () => {
+  expect(() => getCardValue("")).toThrow("No card was played");
+  expect(() => getCardValue("1009♣")).toThrow("Invalid card played, rank and suit cannot be less " +
+      "than 1 or more than 3")
+
+});
+
+
 
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation: