updated test cases for the function

Author: bodoszidi

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -22,15 +22,18 @@
 // execute the code to ensure all tests pass.
 
 function getCardValue(card) {
+  if (Number(card) < 1 || Number(card) > 11) {
+    throw new Error("Error");
+  }
   const removeSuit = card.slice(0, -1);
   if (removeSuit === "A") {
     return 11;
-  } else if (removeSuit === "J" || removeSuit === "Q" ||removeSuit === "K") {
+  } else if (removeSuit === "J" || removeSuit === "Q" || removeSuit === "K") {
     return 10;
   } else if (removeSuit > 1 && removeSuit < 11) {
     return Number(removeSuit);
   } else {
-    throw new Error("Error")
+    throw new Error("Error");
   }
 }
 
@@ -74,4 +77,3 @@ try {
 } catch (e) {
   console.log("Error thrown for invalid card 🎉");
 }
-

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -7,20 +7,24 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 // Special case: numerator is zero
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
+  expect(isProperFraction(-1, 0)).toEqual(false);
+  expect(isProperFraction(0, 0)).toEqual(false);
 });
-test(`should return true when denominator is smaller or equal to the numerator`,() =>{
+test(`should return true when denominator is smaller or equal to the numerator`, () => {
   expect(isProperFraction(2, 4)).toEqual(true);
   expect(isProperFraction(3, 3)).toEqual(true);
   expect(isProperFraction(5, 10)).toEqual(true);
   expect(isProperFraction(2, 2)).toEqual(true);
 });
-  
+
 test(`should return false when denominator is bigger than the numerator`, () => {
   expect(isProperFraction(12, 4)).toEqual(false);
+  expect(isProperFraction(2, 1)).toEqual(false);
 });
 
 test("should return false when the numerator or denominator is not a positive number", () => {
   expect(isProperFraction(5, -2)).toEqual(false);
-  expect(isProperFraction(-1, 0)).toEqual(false);
+  expect(isProperFraction(12, -44)).toEqual(false);
 });
 
+

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -8,9 +8,7 @@ const getCardValue = require("../implement/3-get-card-value");
 test(`Should return 11 when given an ace card`, () => {
   expect(getCardValue("A♠")).toEqual(11);
 });
-
-// Case 2: 
-
+// Case 2:
 test(`should return 10 for face cards"`, () => {
   expect(getCardValue("J♥")).toEqual(10);
   expect(getCardValue("K♠")).toEqual(10);
@@ -20,10 +18,9 @@ test(`should return 10 for face cards"`, () => {
 //Case 3:
 test(`should return the numeric value of numbered cards`, () => {
   expect(getCardValue("2♠")).toEqual(2);
-  expect(getCardValue("5♠")).toEqual(5);
-  expect(getCardValue("8♠")).toEqual(8);
+  expect(getCardValue("5♣")).toEqual(5);
+  expect(getCardValue("8◆")).toEqual(8);
 });
-
 // Suggestion: Group the remaining test data into these categories:
 //   Number Cards (2-10)
 //   Face Cards (J, Q, K)
@@ -35,5 +32,9 @@ test(`should return the numeric value of numbered cards`, () => {
 test(`Should not return any card should throw an error message`, () => {
   expect(() => {
     getCardValue("QQ♥");
+    getCardValue("♠♥");
+    getCardValue("88");
+    getCardValue("00");
+    getCardValue("0");
   }).toThrow();
 });