Skip to content

Commit bc39a33

Browse files
authored
Refactor sayHello function to eliminate dead code
Removed redundant greeting string construction and unreachable console log.
1 parent b31a586 commit bc39a33

1 file changed

Lines changed: 20 additions & 0 deletions

File tree

Sprint-3/3-dead-code/exercise-1.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,23 @@ testName = "Aman";
1515
const greetingMessage = sayHello(greeting, testName);
1616

1717
console.log(greetingMessage); // 'hello, Aman!'
18+
19+
//I have removed "const greetingStr = greeting + ", " + name + "!";" because it serves the same purpose as "return `${greeting}, ${name}!`;",
20+
//making it redundant.
21+
22+
//Also, "console.log(greetingStr);" comes after "return `${greeting}, ${name}!`;", making it unreachable inside the function, since eveything
23+
//after "return" is ignored.
24+
25+
26+
let testName = "Jerry";
27+
const greeting = "hello";
28+
29+
function sayHello(greeting, name) {
30+
return `${greeting}, ${name}!`;
31+
}
32+
33+
testName = "Khaliun";
34+
35+
const greetingMessage = sayHello(greeting, testName);
36+
37+
console.log(greetingMessage); // "hello, Khaliun!"

0 commit comments

Comments
 (0)