fixing codes based on mentor feedback

Author: Abduhasen

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -20,13 +20,13 @@ function getAngleType(angle) {
   } else if (angle === 90) {
     return "Right angle";
   } else if (90 < angle && angle < 180) {
-    return "Obtuse angles";
+    return "Obtuse angle";
   } else if (angle === 180) {
     return "Straight angle";
   } else if (180 < angle && angle < 360) {
-    return "Reflex angles";
+    return "Reflex angle";
   } else {
-    return "Invalid angles";
+    return "Invalid angle";
   }
 }
 

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -13,11 +13,7 @@
 function isProperFraction(numerator, denominator) {
   if (Math.abs(numerator) < Math.abs(denominator)) {
     return true;
-  } else if (denominator === 0) {
-    return false;
-  } else {
-    return false;
-  }
+  } else return false;
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -22,7 +22,7 @@
 // execute the code to ensure all tests pass.
 
 function getCardValue(card) {
-  const validRank = [
+  const validRanks = [
     "A",
     "2",
     "3",
@@ -43,7 +43,7 @@ function getCardValue(card) {
   if (!validSuits.includes(suit)) {
     throw new Error("Invalid Cards");
   }
-  if (!validRank.includes(rank)) {
+  if (!validRanks.includes(rank)) {
     throw new Error("Invalid Cards");
   }
   if (rank === "A") {

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -8,7 +8,7 @@ const getAngleType = require("../implement/1-get-angle-type");
 // Case 1: Acute angles
 test(`should return "Acute angle" when (0 < angle < 90)`, () => {
   // Test various acute angles, including boundary cases
-  expect(getAngleType(1)).toEqual("Acute angle");
+  expect(getAngleType(0.1)).toEqual("Acute angle");
   expect(getAngleType(45)).toEqual("Acute angle");
   expect(getAngleType(89)).toEqual("Acute angle");
 });
@@ -18,30 +18,32 @@ test(`should return "Right angle" when (angle === 90 )`, () => {
   expect(getAngleType(90)).toEqual("Right angle");
 });
 // Case 3: Obtuse angles
-test(`should return "Obtuse angles" when (90 < angle < 180)`, () => {
-  expect(getAngleType(91)).toEqual("Obtuse angles");
-  expect(getAngleType(179)).toEqual("Obtuse angles");
-  expect(getAngleType(145)).toEqual("Obtuse angles");
-  expect(getAngleType(92)).toEqual("Obtuse angles");
-  expect(getAngleType(178)).toEqual("Obtuse angles");
+test(`should return "Obtuse angle" when (90 < angle < 180)`, () => {
+  expect(getAngleType(91)).toEqual("Obtuse angle");
+  expect(getAngleType(179.99999)).toEqual("Obtuse angle");
+  expect(getAngleType(145)).toEqual("Obtuse angle");
+  expect(getAngleType(92)).toEqual("Obtuse angle");
+  expect(getAngleType(178)).toEqual("Obtuse angle");
 });
 // Case 4: Straight angle
 test(`should return "Straight angle" when (angle === 180)`, () => {
   expect(getAngleType(180)).toEqual("Straight angle");
 });
 // Case 5: Reflex angles
-test(`should return "Reflex angles" when (180 < angle < 360)`, () => {
-  expect(getAngleType(181)).toEqual("Reflex angles");
-  expect(getAngleType(190)).toEqual("Reflex angles");
-  expect(getAngleType(345)).toEqual("Reflex angles");
-  expect(getAngleType(359)).toEqual("Reflex angles");
-  expect(getAngleType(277)).toEqual("Reflex angles");
+test(`should return "Reflex angle" when (180 < angle < 360)`, () => {
+  expect(getAngleType(180.01)).toEqual("Reflex angle");
+  expect(getAngleType(190)).toEqual("Reflex angle");
+  expect(getAngleType(345)).toEqual("Reflex angle");
+  expect(getAngleType(359.5)).toEqual("Reflex angle");
+  expect(getAngleType(277)).toEqual("Reflex angle");
 });
 // Case 6: Invalid angles
-test(`should return "Invalid angles" when (angle )`, () => {
-  expect(getAngleType(-60)).toEqual("Invalid angles");
-  expect(getAngleType(450)).toEqual("Invalid angles");
-  expect(getAngleType(-2)).toEqual("Invalid angles");
-  expect(getAngleType(361)).toEqual("Invalid angles");
-  expect(getAngleType(890)).toEqual("Invalid angles");
+test(`should return "Invalid angle" when angle is less than 0 or greater than 360`, () => {
+  expect(getAngleType(-60)).toEqual("Invalid angle");
+  expect(getAngleType(450)).toEqual("Invalid angle");
+  expect(getAngleType(-1)).toEqual("Invalid angle");
+  expect(getAngleType(360)).toEqual("Invalid angle");
+  expect(getAngleType(890)).toEqual("Invalid angle");
+  expect(getAngleType(0)).toEqual("Invalid angle");
+  expect(getAngleType(360.01)).toEqual("Invalid angle");
 });

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -8,12 +8,14 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
-test(`should return false when the denominator less nominator`, () => {
+test(`should return false when the abs(denominator) less abs(numerator)`, () => {
   expect(isProperFraction(7, 2)).toEqual(false);
   expect(isProperFraction(-17, -2)).toEqual(false);
-  expect(isProperFraction(0.5, 0.1)).toEqual(false);
+  expect(isProperFraction(1, 0)).toEqual(false);
+  expect(isProperFraction(0, 0)).toEqual(false);
+  expect(isProperFraction(2, -2)).toEqual(false);
 });
-test(`should return true when denominator is greater than nominator`, () => {
+test(`should return true when abs(denominator) is greater than abs(numerator)`, () => {
   expect(isProperFraction(2, 8)).toEqual(true);
   expect(isProperFraction(-3, -10)).toEqual(true);
   expect(isProperFraction(-3, 7)).toEqual(true);