From 797a947d69be44af3027e7434255b143216a2c76 Mon Sep 17 00:00:00 2001 From: Brian Yorachi Date: Mon, 16 Nov 2026 14:59:23 +0000 Subject: [PATCH 1/7] test: cover quote repetition --- .../quote-generator/quotes-repeat.test.js | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 Sprint-3/quote-generator/quotes-repeat.test.js diff --git a/Sprint-3/quote-generator/quotes-repeat.test.js b/Sprint-3/quote-generator/quotes-repeat.test.js new file mode 100644 index 000000000..06b309794 --- /dev/null +++ b/Sprint-3/quote-generator/quotes-repeat.test.js @@ -0,0 +1,42 @@ +const path = require("path"); +const { JSDOM } = require("jsdom"); + +let page = null; + +afterEach(() => { + if (page) { + page.window.close(); + } + page = null; + jest.restoreAllMocks(); +}); + +test("does not repeat the displayed quote", async () => { + page = await JSDOM.fromFile(path.join(__dirname, "index.html"), { + resources: "usable", + runScripts: "dangerously", + beforeParse(window) { + jest.spyOn(window.Math, "random").mockReturnValue(0.02); + }, + }); + + await new Promise((resolve) => { + page.window.document.addEventListener("load", resolve); + }); + + const quote = page.window.document.querySelector("#quote"); + const author = page.window.document.querySelector("#author"); + const initialQuote = + "Strive not to be a success, but rather to be of value."; + const initialAuthor = "Albert Einstein"; + + expect(quote).toHaveTextContent(initialQuote); + expect(author).toHaveTextContent(initialAuthor); + + page.window.document.querySelector("#new-quote").click(); + + expect(quote).toHaveTextContent( + "Two roads diverged in a wood, and I—I took the one less traveled by, And that has made all the difference." + ); + expect(author).toHaveTextContent("Robert Frost"); +}); From 6f648ecf3f9afd79213ea22eb2ed52ca6e0961b5 Mon Sep 17 00:00:00 2001 From: Brian Yorachi Date: Mon, 16 Nov 2026 14:59:40 +0000 Subject: [PATCH 2/7] chore: set quote generator page title --- Sprint-3/quote-generator/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sprint-3/quote-generator/index.html b/Sprint-3/quote-generator/index.html index 30b434bcf..5f6a720f1 100644 --- a/Sprint-3/quote-generator/index.html +++ b/Sprint-3/quote-generator/index.html @@ -3,7 +3,7 @@ - Title here + Quote generator app From 4f33189de648e02424dde1ac0cccad121496c4e2 Mon Sep 17 00:00:00 2001 From: Brian Yorachi Date: Mon, 16 Nov 2026 15:00:00 +0000 Subject: [PATCH 3/7] chore: name quote generator page --- Sprint-3/quote-generator/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sprint-3/quote-generator/index.html b/Sprint-3/quote-generator/index.html index 5f6a720f1..ba66359c1 100644 --- a/Sprint-3/quote-generator/index.html +++ b/Sprint-3/quote-generator/index.html @@ -7,7 +7,7 @@ -

hello there

+

Quote Generator

From c53f54d6153a57debccf861f6d44a21672593ca6 Mon Sep 17 00:00:00 2001 From: Brian Yorachi Date: Mon, 16 Nov 2026 15:00:20 +0000 Subject: [PATCH 4/7] feat: display random quote on page load --- Sprint-3/quote-generator/quotes.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Sprint-3/quote-generator/quotes.js b/Sprint-3/quote-generator/quotes.js index 4a4d04b72..c27773d97 100644 --- a/Sprint-3/quote-generator/quotes.js +++ b/Sprint-3/quote-generator/quotes.js @@ -490,4 +490,10 @@ const quotes = [ }, ]; -// call pickFromArray with the quotes array to check you get a random quote +function displayQuote() { + const selectedQuote = pickFromArray(quotes); + document.querySelector("#quote").textContent = selectedQuote.quote; + document.querySelector("#author").textContent = selectedQuote.author; +} + +displayQuote(); From 7e623b1f1c4771a35a449bdd3762461ed56eaf50 Mon Sep 17 00:00:00 2001 From: Brian Yorachi Date: Mon, 16 Nov 2026 15:00:37 +0000 Subject: [PATCH 5/7] feat: update quote on button click --- Sprint-3/quote-generator/quotes.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Sprint-3/quote-generator/quotes.js b/Sprint-3/quote-generator/quotes.js index c27773d97..7dbcc458c 100644 --- a/Sprint-3/quote-generator/quotes.js +++ b/Sprint-3/quote-generator/quotes.js @@ -496,4 +496,8 @@ function displayQuote() { document.querySelector("#author").textContent = selectedQuote.author; } +document + .querySelector("#new-quote") + .addEventListener("click", displayQuote); + displayQuote(); From bde613f487fe200dbfaf1e044e047b36846b2509 Mon Sep 17 00:00:00 2001 From: Brian Yorachi Date: Mon, 16 Nov 2026 15:01:08 +0000 Subject: [PATCH 6/7] fix: avoid repeating displayed quote --- Sprint-3/quote-generator/quotes.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Sprint-3/quote-generator/quotes.js b/Sprint-3/quote-generator/quotes.js index 7dbcc458c..2a99179cb 100644 --- a/Sprint-3/quote-generator/quotes.js +++ b/Sprint-3/quote-generator/quotes.js @@ -490,8 +490,16 @@ const quotes = [ }, ]; +let currentQuote; + function displayQuote() { - const selectedQuote = pickFromArray(quotes); + let selectedQuote = pickFromArray(quotes); + if (selectedQuote === currentQuote) { + const currentIndex = quotes.indexOf(currentQuote); + selectedQuote = quotes[(currentIndex + 1) % quotes.length]; + } + currentQuote = selectedQuote; + document.querySelector("#quote").textContent = selectedQuote.quote; document.querySelector("#author").textContent = selectedQuote.author; } From 0f6f506f1bbaec8fe3a9924c2444926fac89e472 Mon Sep 17 00:00:00 2001 From: Brian Yorachi Date: Mon, 16 Nov 2026 15:10:25 +0000 Subject: [PATCH 7/7] test: wait safely for quote page load --- Sprint-3/quote-generator/quotes-repeat.test.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Sprint-3/quote-generator/quotes-repeat.test.js b/Sprint-3/quote-generator/quotes-repeat.test.js index 06b309794..a990d5b25 100644 --- a/Sprint-3/quote-generator/quotes-repeat.test.js +++ b/Sprint-3/quote-generator/quotes-repeat.test.js @@ -20,9 +20,11 @@ test("does not repeat the displayed quote", async () => { }, }); - await new Promise((resolve) => { - page.window.document.addEventListener("load", resolve); - }); + if (page.window.document.readyState !== "complete") { + await new Promise((resolve) => { + page.window.addEventListener("load", resolve, { once: true }); + }); + } const quote = page.window.document.querySelector("#quote"); const author = page.window.document.querySelector("#author");