You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because HiddenManager.hidden is a static that's shared between the internal server and the client when you're in single player, modifying it on one side while it's being iterated on the other side can cause a CME.
https://gnomebot.dev/paste/mclogs/9clgQn9
Because
HiddenManager.hiddenis a static that's shared between the internal server and the client when you're in single player, modifying it on one side while it's being iterated on the other side can cause a CME.It get modified here after the client sync https://github.com/Cmdpro/Databank/blob/main/src/main/java/com/cmdpro/databank/handlers/ModEventHandler.java#L52
while on the client it's being cleared and refilled.
These two lines https://github.com/Cmdpro/Databank/blob/main/src/main/java/com/cmdpro/databank/networking/packet/HiddenSyncS2CPacket.java#L41-L42
need to be
HiddenManager.hidden = new HashMap<>(hidden);