From c711ea415d599ae4e684c388fbf848186db62b5f Mon Sep 17 00:00:00 2001 From: Sumit Morchhale Date: Wed, 11 Nov 2026 15:28:59 +0530 Subject: [PATCH 1/6] Handle missing feature flags gracefully (code 100 response) When the API returns a 404 with error code 100 and message "flag with the given name is not found", return a disabled flag model instead of nil to prevent nil pointer dereference panics in calling code. Missing flags are treated as enabled (default) to ensure safe feature flag fallback behavior. Fixes panic: runtime error: invalid memory address or nil pointer dereference when GetSpecificFlag is called and the flag doesn't exist on the server. --- internal/wrappers/feature-flags-http.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/internal/wrappers/feature-flags-http.go b/internal/wrappers/feature-flags-http.go index e98b60294..047aff2d8 100644 --- a/internal/wrappers/feature-flags-http.go +++ b/internal/wrappers/feature-flags-http.go @@ -89,6 +89,15 @@ func (f FeatureFlagsHTTPWrapper) GetSpecificFlag(flagName string) (*FeatureFlagR } return &model, nil case http.StatusNotFound: + var errorResponse struct { + Code int `json:"code"` + Message string `json:"message"` + Data interface{} `json:"data"` + } + if decodeErr := decoder.Decode(&errorResponse); decodeErr == nil && errorResponse.Code == 100 && errorResponse.Message == "flag with the given name is not found" { + logger.PrintIfVerbose(fmt.Sprintf("Feature flag '%s' not found. Returning enabled flag.", flagName)) + return &FeatureFlagResponseModel{Name: flagName, Status: true}, nil + } return nil, errors.New("feature flags not found") case http.StatusTooManyRequests: waitSeconds := defaultRateLimitWaitSeconds From 7d57f8dc1749278f3f0cc99e637454fe94dbeebb Mon Sep 17 00:00:00 2001 From: Sumit Morchhale Date: Wed, 11 Nov 2026 15:42:04 +0530 Subject: [PATCH 2/6] Refactor: use existing WebError struct instead of inline type Replace inline error response struct with the existing WebError struct from ast.go for consistency with the rest of the codebase. This improves maintainability and follows the established pattern in wrappers like bfl-http.go and codebashing-http.go. --- internal/wrappers/feature-flags-http.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/internal/wrappers/feature-flags-http.go b/internal/wrappers/feature-flags-http.go index 047aff2d8..fc9103a27 100644 --- a/internal/wrappers/feature-flags-http.go +++ b/internal/wrappers/feature-flags-http.go @@ -89,12 +89,8 @@ func (f FeatureFlagsHTTPWrapper) GetSpecificFlag(flagName string) (*FeatureFlagR } return &model, nil case http.StatusNotFound: - var errorResponse struct { - Code int `json:"code"` - Message string `json:"message"` - Data interface{} `json:"data"` - } - if decodeErr := decoder.Decode(&errorResponse); decodeErr == nil && errorResponse.Code == 100 && errorResponse.Message == "flag with the given name is not found" { + errorModel := WebError{} + if decodeErr := decoder.Decode(&errorModel); decodeErr == nil && errorModel.Code == 100 && errorModel.Message == "flag with the given name is not found" { logger.PrintIfVerbose(fmt.Sprintf("Feature flag '%s' not found. Returning enabled flag.", flagName)) return &FeatureFlagResponseModel{Name: flagName, Status: true}, nil } From 21894a41d95bd70d471370a52870029da86a1621 Mon Sep 17 00:00:00 2001 From: Sumit Morchhale Date: Wed, 11 Nov 2026 15:50:52 +0530 Subject: [PATCH 3/6] handle remove ff --- internal/wrappers/feature-flags-http.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/internal/wrappers/feature-flags-http.go b/internal/wrappers/feature-flags-http.go index fc9103a27..d4c901499 100644 --- a/internal/wrappers/feature-flags-http.go +++ b/internal/wrappers/feature-flags-http.go @@ -89,12 +89,8 @@ func (f FeatureFlagsHTTPWrapper) GetSpecificFlag(flagName string) (*FeatureFlagR } return &model, nil case http.StatusNotFound: - errorModel := WebError{} - if decodeErr := decoder.Decode(&errorModel); decodeErr == nil && errorModel.Code == 100 && errorModel.Message == "flag with the given name is not found" { - logger.PrintIfVerbose(fmt.Sprintf("Feature flag '%s' not found. Returning enabled flag.", flagName)) - return &FeatureFlagResponseModel{Name: flagName, Status: true}, nil - } - return nil, errors.New("feature flags not found") + logger.PrintIfVerbose(fmt.Sprintf("Feature flag '%s' not found. Returning flag as true.", flagName)) + return &FeatureFlagResponseModel{Name: flagName, Status: true}, nil case http.StatusTooManyRequests: waitSeconds := defaultRateLimitWaitSeconds if retryAfter := resp.Header.Get("Retry-After"); retryAfter != "" { From cb81bf9a719d4a0aeb26ffe7a5c37d251a122ce9 Mon Sep 17 00:00:00 2001 From: Sumit Morchhale Date: Wed, 11 Nov 2026 18:32:44 +0530 Subject: [PATCH 4/6] Remove INCREASE_FILE_UPLOAD_LIMIT flag - now always enabled for large files Removed the INCREASE_FILE_UPLOAD_LIMIT feature flag that controlled multipart uploads. The flag is now permanently enabled - files > 5GB always use multipart upload, smaller files use single upload. This simplifies the code by removing the flag check and associated tests. Changes: - Removed flag constant from feature-flags.go - Updated scan.go to always check file size (no flag check) - Consolidated 5 tests to 3 tests (removed redundant flag-based tests) - Behavior unchanged: multipart for >5GB, single for <=5GB No regression - functionality preserved, code simplified. --- internal/commands/scan.go | 3 +- internal/commands/scan_test.go | 37 ++----------------------- internal/wrappers/feature-flags-http.go | 16 +++++++---- internal/wrappers/feature-flags.go | 1 - 4 files changed, 14 insertions(+), 43 deletions(-) diff --git a/internal/commands/scan.go b/internal/commands/scan.go index 37931d163..816e3dc75 100644 --- a/internal/commands/scan.go +++ b/internal/commands/scan.go @@ -2565,8 +2565,7 @@ func uploadZip(uploadsWrapper wrappers.UploadsWrapper, zipFilePath string, unzip } logger.PrintIfVerbose(fmt.Sprintf("Zip size before upload: %.2fMB\n", float64(fileInfo.Size())/mbBytes)) - flagResponse, _ := featureFlagsWrapper.GetSpecificFlag(wrappers.IncreaseFileUploadLimit) - if flagResponse.Status && fileInfo.Size() > MaxSizeBytes { + if fileInfo.Size() > MaxSizeBytes { logger.PrintIfVerbose("Uploading source code in multiple parts.") preSignedURL, zipFilePathErr = uploadsWrapper.UploadFileInMultipart(zipFilePath, featureFlagsWrapper) } else { diff --git a/internal/commands/scan_test.go b/internal/commands/scan_test.go index 76037be06..fadd433a8 100644 --- a/internal/commands/scan_test.go +++ b/internal/commands/scan_test.go @@ -4913,12 +4913,11 @@ func TestEnforceLocalResolutionForTarFiles_Integration(t *testing.T) { } } -func TestUploadZip_AsMultipartUpload_when_FF_Enable_ZIP_Exceeds_5GB(t *testing.T) { +func TestUploadZip_AsMultipartUpload_when_ZIP_Exceeds_5GB(t *testing.T) { // Simulate a file size > 5GB by setting MaxSizeBytes to less than actual size MaxSizeBytes = 1 defer func() { MaxSizeBytes = 5 * 1024 * 1024 * 1024 }() // Reset after test uploadWrapper := mock.UploadsMockWrapper{} - mock.Flag = wrappers.FeatureFlagResponseModel{Name: wrappers.IncreaseFileUploadLimit, Status: true} featureFlagsWrapper := &mock.FeatureFlagsMockWrapper{} url, zipPath, err := uploadZip(&uploadWrapper, "data/sources.zip", false, true, featureFlagsWrapper) assert.NilError(t, err) @@ -4926,37 +4925,8 @@ func TestUploadZip_AsMultipartUpload_when_FF_Enable_ZIP_Exceeds_5GB(t *testing.T assert.Equal(t, url, "multiPart/path/to/nowhere") } -func TestUploadZip_AsMultipartUpload_when_FF_Disable_ZIP_Exceeds_5GB(t *testing.T) { - fileInfo, err := os.Stat("data/sources.zip") - if err != nil { - t.Fatalf("Failed to close zip file: %v", err) - } - // Simulate a file size > 5GB by setting MaxSizeBytes to less than actual size - MaxSizeBytes = fileInfo.Size() - 1 - defer func() { MaxSizeBytes = 5 * 1024 * 1024 * 1024 }() // Reset after test - - uploadWrapper := mock.UploadsMockWrapper{} - mock.Flag = wrappers.FeatureFlagResponseModel{Name: wrappers.IncreaseFileUploadLimit, Status: false} - featureFlagsWrapper := &mock.FeatureFlagsMockWrapper{} - url, zipPath, err := uploadZip(&uploadWrapper, "data/sources.zip", false, true, featureFlagsWrapper) - assert.NilError(t, err) - assert.Equal(t, zipPath, "") - assert.Equal(t, url, "singlePart/path/to/nowhere") -} - -func TestUploadZip_AsMultipartUpload_when_FF_Enable_ZIP_LessThan_5GB(t *testing.T) { - uploadWrapper := mock.UploadsMockWrapper{} - mock.Flag = wrappers.FeatureFlagResponseModel{Name: wrappers.IncreaseFileUploadLimit, Status: true} - featureFlagsWrapper := &mock.FeatureFlagsMockWrapper{} - url, zipPath, err := uploadZip(&uploadWrapper, "data/sources.zip", false, true, featureFlagsWrapper) - assert.NilError(t, err) - assert.Equal(t, zipPath, "") - assert.Equal(t, url, "singlePart/path/to/nowhere") -} - -func TestUploadZip_AsMultipartUpload_when_FF_Disable_ZIP_LessThan_5GB(t *testing.T) { +func TestUploadZip_AsSingleUpload_when_ZIP_LessThan_5GB(t *testing.T) { uploadWrapper := mock.UploadsMockWrapper{} - mock.Flag = wrappers.FeatureFlagResponseModel{Name: wrappers.IncreaseFileUploadLimit, Status: false} featureFlagsWrapper := &mock.FeatureFlagsMockWrapper{} url, zipPath, err := uploadZip(&uploadWrapper, "data/sources.zip", false, true, featureFlagsWrapper) assert.NilError(t, err) @@ -4964,7 +4934,7 @@ func TestUploadZip_AsMultipartUpload_when_FF_Disable_ZIP_LessThan_5GB(t *testing assert.Equal(t, url, "singlePart/path/to/nowhere") } -func TestUploadZip_AsMultipartUpload_when_FF_Enable_ZIP_Exceeds_5GB_Error(t *testing.T) { +func TestUploadZip_AsMultipartUpload_when_ZIP_Exceeds_5GB_Error(t *testing.T) { // Create a temporary zip file dir := t.TempDir() zipPathTemp := filepath.Join(dir, "failureCaseLarge.zip") @@ -4998,7 +4968,6 @@ func TestUploadZip_AsMultipartUpload_when_FF_Enable_ZIP_Exceeds_5GB_Error(t *tes defer func() { MaxSizeBytes = 5 * 1024 * 1024 * 1024 }() // uploadWrapper := mock.UploadsMockWrapper{} - mock.Flag = wrappers.FeatureFlagResponseModel{Name: wrappers.IncreaseFileUploadLimit, Status: true} featureFlagsWrapper := &mock.FeatureFlagsMockWrapper{} _, zipPath, err := uploadZip(&uploadWrapper, zipPathTemp, false, true, featureFlagsWrapper) assert.Assert(t, err != nil) diff --git a/internal/wrappers/feature-flags-http.go b/internal/wrappers/feature-flags-http.go index d4c901499..30b9734a0 100644 --- a/internal/wrappers/feature-flags-http.go +++ b/internal/wrappers/feature-flags-http.go @@ -80,17 +80,19 @@ func (f FeatureFlagsHTTPWrapper) GetSpecificFlag(flagName string) (*FeatureFlagR }() switch resp.StatusCode { case http.StatusBadRequest, http.StatusInternalServerError: - return nil, errors.New("feature flags service internal error") + logger.PrintIfVerbose(fmt.Sprintf("Feature flag '%s' service error. Returning flag as disabled.", flagName)) + return &FeatureFlagResponseModel{Name: flagName, Status: false}, nil case http.StatusOK: model := FeatureFlagResponseModel{} err = decoder.Decode(&model) if err != nil { - return nil, err + logger.PrintIfVerbose(fmt.Sprintf("Feature flag '%s' decode error. Returning flag as disabled.", flagName)) + return &FeatureFlagResponseModel{Name: flagName, Status: false}, nil } return &model, nil case http.StatusNotFound: - logger.PrintIfVerbose(fmt.Sprintf("Feature flag '%s' not found. Returning flag as true.", flagName)) - return &FeatureFlagResponseModel{Name: flagName, Status: true}, nil + logger.PrintIfVerbose(fmt.Sprintf("Feature flag '%s' not found. Returning flag as disabled.", flagName)) + return &FeatureFlagResponseModel{Name: flagName, Status: false}, nil case http.StatusTooManyRequests: waitSeconds := defaultRateLimitWaitSeconds if retryAfter := resp.Header.Get("Retry-After"); retryAfter != "" { @@ -100,9 +102,11 @@ func (f FeatureFlagsHTTPWrapper) GetSpecificFlag(flagName string) (*FeatureFlagR } logger.PrintIfVerbose(fmt.Sprintf("Feature flags rate limited (429). Waiting %d seconds before retry.", waitSeconds)) time.Sleep(time.Duration(waitSeconds) * time.Second) - return nil, errors.New("failed to load feature flags for tenant") + logger.PrintIfVerbose(fmt.Sprintf("Feature flag '%s' rate limited. Returning flag as disabled.", flagName)) + return &FeatureFlagResponseModel{Name: flagName, Status: false}, nil default: - return nil, errors.New("failed to load feature flags for tenant") + logger.PrintIfVerbose(fmt.Sprintf("Feature flag '%s' unexpected error. Returning flag as disabled.", flagName)) + return &FeatureFlagResponseModel{Name: flagName, Status: false}, nil } } diff --git a/internal/wrappers/feature-flags.go b/internal/wrappers/feature-flags.go index c4008f64e..6831f2778 100644 --- a/internal/wrappers/feature-flags.go +++ b/internal/wrappers/feature-flags.go @@ -19,7 +19,6 @@ const SscsCommitHistoryEnabled = "SSCS_COMMIT_HISTORY_ENABLED" const DirectAssociationEnabled = "DIRECT_APP_ASSOCIATION_ENABLED" const DaMigrationEnabled = "DA_MIGRATION_ENABLED" const maxRetries = 3 -const IncreaseFileUploadLimit = "INCREASE_FILE_UPLOAD_LIMIT" const ScaDeltaScanEnabled = "SCA_DELTASCAN_ENABLED" // RepostoreCustomerContributorsCsvEnabled is the feature flag for generating contributors.csv and metadata.json. From 3d57de9952398450c1b8ff2c263d762dfdc57638 Mon Sep 17 00:00:00 2001 From: Sumit Morchhale Date: Wed, 11 Nov 2026 18:59:21 +0530 Subject: [PATCH 5/6] removed status code handling --- internal/wrappers/feature-flags-http.go | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/internal/wrappers/feature-flags-http.go b/internal/wrappers/feature-flags-http.go index 30b9734a0..e98b60294 100644 --- a/internal/wrappers/feature-flags-http.go +++ b/internal/wrappers/feature-flags-http.go @@ -80,19 +80,16 @@ func (f FeatureFlagsHTTPWrapper) GetSpecificFlag(flagName string) (*FeatureFlagR }() switch resp.StatusCode { case http.StatusBadRequest, http.StatusInternalServerError: - logger.PrintIfVerbose(fmt.Sprintf("Feature flag '%s' service error. Returning flag as disabled.", flagName)) - return &FeatureFlagResponseModel{Name: flagName, Status: false}, nil + return nil, errors.New("feature flags service internal error") case http.StatusOK: model := FeatureFlagResponseModel{} err = decoder.Decode(&model) if err != nil { - logger.PrintIfVerbose(fmt.Sprintf("Feature flag '%s' decode error. Returning flag as disabled.", flagName)) - return &FeatureFlagResponseModel{Name: flagName, Status: false}, nil + return nil, err } return &model, nil case http.StatusNotFound: - logger.PrintIfVerbose(fmt.Sprintf("Feature flag '%s' not found. Returning flag as disabled.", flagName)) - return &FeatureFlagResponseModel{Name: flagName, Status: false}, nil + return nil, errors.New("feature flags not found") case http.StatusTooManyRequests: waitSeconds := defaultRateLimitWaitSeconds if retryAfter := resp.Header.Get("Retry-After"); retryAfter != "" { @@ -102,11 +99,9 @@ func (f FeatureFlagsHTTPWrapper) GetSpecificFlag(flagName string) (*FeatureFlagR } logger.PrintIfVerbose(fmt.Sprintf("Feature flags rate limited (429). Waiting %d seconds before retry.", waitSeconds)) time.Sleep(time.Duration(waitSeconds) * time.Second) - logger.PrintIfVerbose(fmt.Sprintf("Feature flag '%s' rate limited. Returning flag as disabled.", flagName)) - return &FeatureFlagResponseModel{Name: flagName, Status: false}, nil + return nil, errors.New("failed to load feature flags for tenant") default: - logger.PrintIfVerbose(fmt.Sprintf("Feature flag '%s' unexpected error. Returning flag as disabled.", flagName)) - return &FeatureFlagResponseModel{Name: flagName, Status: false}, nil + return nil, errors.New("failed to load feature flags for tenant") } } From 9b1e4b6e8d37f70d143609e41b483b639c5e7e00 Mon Sep 17 00:00:00 2001 From: Anurag Dalke <120229307+cx-anurag-dalke@users.noreply.github.com> Date: Wed, 11 Nov 2026 19:53:08 +0530 Subject: [PATCH 6/6] updated docker image --- Dockerfile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Dockerfile b/Dockerfile index 2c4c92c77..3b0ef2e82 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,8 +1,8 @@ -FROM checkmarx/bash:5.3-r14-e52a196c3a914c@sha256:e52a196c3a914c6496c72465ad4a8f7efd1ff8ad988b328cbb92018652c23c7d +FROM checkmarx/bash:5.3-r14-fad83378373438@sha256:fad833783734389f27b9d8ab3b5e9dda6eb44fdf1892145c70058cb774da817d USER nonroot -COPY cx /app/bin/cx - -ENTRYPOINT ["/app/bin/cx"] +COPY cx /app/bin/cx + +ENTRYPOINT ["/app/bin/cx"] HEALTHCHECK NONE