More free functions#2038
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2038 +/- ##
==========================================
+ Coverage 95.64% 95.66% +0.01%
==========================================
Files 30 30
Lines 8962 9040 +78
Branches 1328 1344 +16
==========================================
+ Hits 8572 8648 +76
- Misses 240 241 +1
- Partials 150 151 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2038 +/- ##
==========================================
+ Coverage 95.64% 95.73% +0.09%
==========================================
Files 30 30
Lines 8962 9341 +379
Branches 1328 1384 +56
==========================================
+ Hits 8572 8943 +371
- Misses 240 243 +3
- Partials 150 155 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@jmwright @lorenzncode I'm still working on some docs, but I think the code as such is ready to be reviewed. |
lorenzncode
left a comment
There was a problem hiding this comment.
Very interesting! Here are a few initial findings.
| faceOn, | ||
| isSubshape, | ||
| prism, | ||
| hollow, |
There was a problem hiding this comment.
hollow, offset2D listed twice.
| *sn: Shape, | ||
| tol: float = 1e-6, | ||
| history: History | None = None, | ||
| name: str | None = None, |
|
|
||
| # %% alternative constructors | ||
|
|
||
| ShapeHistory = Dict[Union[Shape, str], Shape] |
| res1 = draft(box_shape, fbot, fside, 5) | ||
| assert res1.face(">Z").Area() > fbot.Area() | ||
|
|
||
| # direction specified explicitely |
There was a problem hiding this comment.
| # direction specified explicitely | |
| # direction specified explicitly |
This PR should reach (rough) feature parity with
Shape.*Closes #1812This enables e.g.
selection = f.outerWire() & f.edges('|X')Big experimental change. Added a
HistoryandOpclass. History instance can be passed now to many ops viahistory=kwarg. Name for the operation can be specified vianame=. It can be later queried like so: