Bug: Type 0 ALERT>WARNING block uses structurally dead $suspend_notify guard

[somethingwithproof]

Summary

In thold_functions.php, the Type 0 ALERT > WARNING elseif block is only reached when $notify was false in the prior warning block. The $suspend_notify variable is only ever set to true when $notify && $ra (the reset_ack re-alert suppression condition). Since $notify is false when this elseif path is entered, $suspend_notify is always false here.

This makes the guard if (!$suspend_notify && !$maint_dev) at the top of the ALERT>WARNING notification block structurally dead code — the suspend mechanism can never suppress notifications on this path.

Fix

Implementation in #797.

[somethingwithproof]

While extracting the notification delivery I tried to reach this branch and it does fire: with the threshold already in alert, a reading back inside the warning band, and both fail counts at or above their triggers, it logs ST_NOTIFYAW with an ALERT > WARNING subject. So the branch as a whole is reachable; the report here is specifically about the $suspend_notify guard inside it, which is a separate matter. There is a characterization test covering the branch in #801.