diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 73d88e3..688e49e 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -30,24 +30,12 @@ parameters: count: 3 path: src/BrandEmbassyCodingStandard/Sniffs/Classes/TraitUseSpacingSniffTest.php - - - message: '#^Parameter \#2 \$subject of function preg_match expects string, mixed given\.$#' - identifier: argument.type - count: 1 - path: src/BrandEmbassyCodingStandard/Sniffs/Commenting/CreateMockFunctionReturnTypeOrderSniff.php - - message: '#^Parameter \#4 \$startPointer of static method SlevomatCodingStandard\\Helpers\\TokenHelper\:\:findNextContent\(\) expects int, mixed given\.$#' identifier: argument.type count: 1 path: src/BrandEmbassyCodingStandard/Sniffs/Commenting/CreateMockFunctionReturnTypeOrderSniff.php - - - message: '#^Parameter \#1 \$string of function strtolower expects string, mixed given\.$#' - identifier: argument.type - count: 1 - path: src/BrandEmbassyCodingStandard/Sniffs/ForbiddenElseStatementSniff.php - - message: '#^Binary operation "\-" between mixed and 1 results in an error\.$#' identifier: binaryOp.invalid diff --git a/src/BrandEmbassyCodingStandard/Sniffs/Commenting/CreateMockFunctionReturnTypeOrderSniff.php b/src/BrandEmbassyCodingStandard/Sniffs/Commenting/CreateMockFunctionReturnTypeOrderSniff.php index 604f6ed..31517ff 100644 --- a/src/BrandEmbassyCodingStandard/Sniffs/Commenting/CreateMockFunctionReturnTypeOrderSniff.php +++ b/src/BrandEmbassyCodingStandard/Sniffs/Commenting/CreateMockFunctionReturnTypeOrderSniff.php @@ -5,6 +5,8 @@ use PHP_CodeSniffer\Files\File; use PHP_CodeSniffer\Sniffs\Sniff; use SlevomatCodingStandard\Helpers\TokenHelper; +use function assert; +use function is_string; use function preg_match; use const T_FUNCTION; @@ -80,6 +82,7 @@ public function process(File $phpcsFile, $stackPtr): void } $returnType = $tokens[$returnTypePtr]['content']; + assert(is_string($returnType)); if (preg_match('~^MockInterface&(\w+)$~', $returnType, $matches) !== 1) { return; diff --git a/src/BrandEmbassyCodingStandard/Sniffs/ForbiddenElseStatementSniff.php b/src/BrandEmbassyCodingStandard/Sniffs/ForbiddenElseStatementSniff.php index 3e6df88..7948427 100644 --- a/src/BrandEmbassyCodingStandard/Sniffs/ForbiddenElseStatementSniff.php +++ b/src/BrandEmbassyCodingStandard/Sniffs/ForbiddenElseStatementSniff.php @@ -4,6 +4,8 @@ use PHP_CodeSniffer\Files\File; use PHP_CodeSniffer\Sniffs\Sniff; +use function assert; +use function is_string; use function strtolower; use const T_ELSE; use const T_ELSEIF; @@ -37,7 +39,9 @@ public function process(File $phpcsFile, $stackPtr): void { $tokens = $phpcsFile->getTokens(); - $statement = strtolower($tokens[$stackPtr]['content']); + $content = $tokens[$stackPtr]['content']; + assert(is_string($content)); + $statement = strtolower($content); $error = 'Use of ' . $statement . ' is forbidden. See: https://github.com/BrandEmbassy/developers-manifest/issues/365.';