Skip to content

Off-By-One Error in Subgraph Generation #6

Description

@Jonathan-Rabideau

On line 75 in subgraph_generator.cu, ceil() is useless with integer division.
Should be unsigned int chunkSize = (unsigned int)ceil((double)numActiveNodes / numThreads);

Results in not copying some data to the edge array, sending the old values to the kernel which results in undefined behavior; usually erroneous values in the last .01% of the nodes (but can propagate through the rest of the graph).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions