From e3ad7262c397e97481422ad2c4a8de23fc25b400 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Johannes=20R=C3=B8svik?= <j.rosvik@gmail.com>
Date: Tue, 7 Jul 2026 14:14:53 +0200
Subject: [PATCH] feat!: use plain strings for global message contexts

The previous approach was flawed in that e.g.

  context: ["app-assistant", "web-overview"]

would fail to parse, because `"web-overview"` was unknown to the app,
and `"app-assistant"` was unknown on web.

It would be possible to add filtering to the current solution, but I
think it makes more sense to use plain strings instead, then letting
consumers handle which contexts actually are actually displayed.
---
 src/global-messages/index.ts |  2 +-
 src/global-messages/types.ts | 56 ++++++++++++------------------------
 2 files changed, 20 insertions(+), 38 deletions(-)

diff --git a/src/global-messages/index.ts b/src/global-messages/index.ts
index bf7daf2..67c9158 100644
--- a/src/global-messages/index.ts
+++ b/src/global-messages/index.ts
@@ -1 +1 @@
-export {createGlobalMessageSchema, GenericGlobalMessageType} from './types';
+export {GlobalMessageSchema, GlobalMessageType} from './types';
diff --git a/src/global-messages/types.ts b/src/global-messages/types.ts
index 8239c00..6b1d113 100644
--- a/src/global-messages/types.ts
+++ b/src/global-messages/types.ts
@@ -3,41 +3,23 @@ import {LanguageAndTextSchema} from '../common/language-and-text';
 import {Rule} from '../rules/types';
 import {AppPlatform} from '../common/app-platform';
 
-/**
- * Create a global message schema with a consumer specific context enum.
- *
- * @example
- * export enum GlobalMessageContextEnum {
- *   webOverview = 'web-overview',
- * }
- * const GlobalMessageContextSchema = z.enum(GlobalMessageContextEnum);
- * export const GlobalMessageSchema = createGlobalMessageSchema(
- *   GlobalMessageContextSchema,
- * );
- */
-export function createGlobalMessageSchema<ContextEnum extends z.ZodType>(
-  contextEnum: ContextEnum,
-) {
-  return z.object({
-    id: z.string(),
-    active: z.boolean(),
-    title: z.array(LanguageAndTextSchema).optional(),
-    body: z.array(LanguageAndTextSchema),
-    link: z.array(LanguageAndTextSchema).optional(),
-    linkText: z.array(LanguageAndTextSchema).optional(),
-    type: z.enum(['error', 'valid', 'info', 'warning']),
-    subtle: z.boolean().optional(),
-    context: z.array(contextEnum),
-    isDismissable: z.boolean().optional(),
-    appPlatforms: z.array(AppPlatform).optional(),
-    appVersionMin: z.string().optional(),
-    appVersionMax: z.string().optional(),
-    startDate: z.coerce.date().optional(),
-    endDate: z.coerce.date().optional(),
-    rules: z.array(Rule).optional(),
-  });
-}
+export const GlobalMessageSchema = z.object({
+  id: z.string(),
+  active: z.boolean(),
+  title: z.array(LanguageAndTextSchema).optional(),
+  body: z.array(LanguageAndTextSchema),
+  link: z.array(LanguageAndTextSchema).optional(),
+  linkText: z.array(LanguageAndTextSchema).optional(),
+  type: z.enum(['error', 'valid', 'info', 'warning']),
+  subtle: z.boolean().optional(),
+  context: z.array(z.string()).nonempty(),
+  isDismissable: z.boolean().optional(),
+  appPlatforms: z.array(AppPlatform).optional(),
+  appVersionMin: z.string().optional(),
+  appVersionMax: z.string().optional(),
+  startDate: z.coerce.date().optional(),
+  endDate: z.coerce.date().optional(),
+  rules: z.array(Rule).optional(),
+});
 
-export type GenericGlobalMessageType<ContextEnum extends z.ZodType> = z.infer<
-  ReturnType<typeof createGlobalMessageSchema<ContextEnum>>
->;
+export type GlobalMessageType = z.infer<typeof GlobalMessageSchema>;