Repository navigation
Commit c22d2bd
committed
fix(ui): 棘轮守卫同前缀目录漏判与白名单措辞
两处均为评审者实测抓出、由控制方直接修(非实施者),并自证有效。
1) 棘轮守卫:!f.startsWith(ICONS_DIR) 是裸字符串前缀比较,任何以 icons 开头的同级目录被静默豁免。
评审者双针实测:ui/icons-legacy/Probe.tsx -> exit 0 放行(漏判)。改为比较 ICONS_DIR + sep。
修复后用同一探针复现:exit 1 并点名 ui/icons-legacy/Probe.tsx;移除探针后图标层 21/21 全绿
(证明 ui/icons/ 自身的正常排除未被破坏)。该写法逐字来自计划,属计划缺陷。
2) types.ts 两处注释与 paths.test.ts 用例名称「四种」标签,而 ICON_ELEMENT_TAGS 实为 3 种
(path/circle/rect)。该 Minor 在 T1 任务评审已登记,但当时只修了计划、代码里的措辞留了下来。
零行为变更(守卫判定范围修正除外):tsc exit 0 · 图标层 21/21 · 全量 809/809。1 parent 1da830f commit c22d2bd
3 files changed
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
42 | 44 | | |
43 | 45 | | |
44 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
0 commit comments