fix(audit3): resolve round-3 review findings on round-2 fixes

High:
- OfflineQueue: orderBy('version') on non-indexed field throws Dexie
  SchemaError, breaking offline enqueue (regression from SYNC2-L4);
  switched to sortBy in-memory (enqueue/getPendingItems/getReadyItems)
- auth.py JWKS: network-failure branch now bounded by stale-grace
  window (was unbounded stale reuse); in-lock retry_after reuse
  added; 5xx treated as transient (stale reuse) vs 4xx fail-closed

Medium:
- error_pattern: cache-hit path now validates/filters like first-run
  (was bypassing validation -> 500); cache stores cleaned data;
  negative count/empty keywords filtered
- Key rotation: removed per-provider generate rotate (double rotation
  with wrapper made even-key pools never use the 2nd key)
- writeWithLog: resetTable failure no longer propagates to block the
  main write path
- SyncEngine: finally clears syncInProgress unconditionally (pause
  during in-flight sync left the lock, resume waited 15s timeout)
- feynmanStepSlice: catch path now syncs zustand store so retry does
  not duplicate cards for already-created weak points
- windowManager: window recreation clears syncTimeoutTimer (stale
  timer would app.quit() the rebuilt window)
- rate_limit: global-limit overrun now rolls back the feature counter
  (Lua only rolls back the exceeded layer)

Low:
- markEntityLogsSynced matches synced !== 1 (legacy boolean/undefined)
- parseLocalDate validates format; daysBetween NaN -> Infinity
- ecosystem initialize uses local date; restore() re-reads DB
- worldState streak diff uses Math.round tolerance
- useVoiceInput start timeout surfaces error message
- Gemini stream uses provider thread pool (not default executor)
- qwen_vision returns max_tokens for truncation detection
- jwt_algorithm normalized strip().upper()

Author: Aparencia

client/electron/windowManager.ts

@@ -83,6 +83,13 @@ export function createMainWindow(
   // preventDefault 无法关闭（同步事件只在旧窗口的 webContents 上发送过）
   syncBeforeQuitRequested = false;
   syncBeforeQuitCompleted = false;
+  // GW-3: 同步清理超时定时器——旧 timer 回调检查 !syncBeforeQuitCompleted
+  //（重置后必为 false）会触发 completeSyncBeforeQuit → app.quit()，
+  // 刚重建的窗口被意外退出
+  if (syncTimeoutTimer) {
+    clearTimeout(syncTimeoutTimer);
+    syncTimeoutTimer = null;
+  }
 
   const win = new BrowserWindow({
     width: WINDOW_DEFAULT_WIDTH,

client/src/features/assistant/hooks/useVoiceInput.ts

@@ -94,7 +94,11 @@ export function useVoiceInput(options: UseVoiceInputOptions = {}) {
       while (stopPendingRef.current && Date.now() - waitStart < 5000) {
         await new Promise((r) => setTimeout(r, 50));
       }
-      if (stopPendingRef.current) return; // 超时放弃本次启动
+      if (stopPendingRef.current) {
+        // GW-3: 超时静默放弃会让用户点击无响应——给出明确错误提示
+        setError('停止拾音未完成，请稍后重试');
+        return;
+      }
     }
     setError(null);
 

client/src/features/feynman/store/feynmanStepSlice.ts

@@ -217,6 +217,17 @@ export const createStepSlice: FeynmanSlice<StepSlice> = (set, get) => ({
           // 标记失败可接受：下次转换最多重复建该张卡
         }
       }
+      // GW-3: 同步 store——原实现 catch 后 set() 不执行，store 仍显示未
+      // mastered，重试时 toConvert 从 store 取到已建卡的 wp 再次建卡
+      //（DB 已 mastered 与 UI 态不一致）
+      set((state) => ({
+        weakPoints: {
+          ...state.weakPoints,
+          [noteId]: (state.weakPoints[noteId] ?? []).map((w) =>
+            createdWpIds.includes(w.id!) ? { ...w, mastered: true } : w,
+          ),
+        },
+      }));
       throw err;
     }
 

client/src/features/retention/lib/streakEngine.ts

@@ -16,10 +16,15 @@ const toISO = (d: Date) =>
  * 将本地日期字符串（YYYY-MM-DD）解析为本地午夜 Date
  * FRONT2-M3: new Date("YYYY-MM-DD") 会按 UTC 午夜解析，UTC+8 时
  * lastDate 实际落在前一天的 08:00，与本地日期的 today 间隔计算差一天
+ * GW-3: 格式校验——异常数据（空串/ISO 串）会生成 Invalid Date 或
+ * 1899 年日期，导致 gap 计算失真；不匹配时回退原生解析并容忍 NaN
  */
 function parseLocalDate(dateStr: string): Date {
-  const [y, m, d] = dateStr.split('-').map(Number);
-  return new Date(y, m - 1, d);
+  if (/^\d{4}-\d{2}-\d{2}$/.test(dateStr)) {
+    const [y, m, d] = dateStr.split('-').map(Number);
+    return new Date(y, m - 1, d);
+  }
+  return new Date(dateStr);
 }
 
 /** 断裂后保留百分比 / Retained percent after break */
@@ -36,9 +41,13 @@ export function isRestDay(date: Date, restDayPreference: number): boolean {
 /**
  * 计算两个日期之间的天数差（不含起始日）
  * Calculate day difference between two dates (exclusive of start)
+ * GW-3: 异常日期（Invalid Date）按 Infinity 处理——走断裂语义
+ *（保留 50%）而非 NaN 传播导致连击被静默错误计算
  */
 function daysBetween(a: Date, b: Date): number {
-  return Math.floor((b.getTime() - a.getTime()) / 86_400_000);
+  const diff = b.getTime() - a.getTime();
+  if (Number.isNaN(diff)) return Infinity;
+  return Math.floor(diff / 86_400_000);
 }
 
 /**

client/src/features/retention/lib/worldState.ts

@@ -88,7 +88,10 @@ export function computeCurrentStreakFromCorals(corals: CoralRecord[]): number {
   for (let i = 1; i < uniqueDays.length; i++) {
     const prev = new Date(uniqueDays[i - 1]).getTime();
     const curr = new Date(uniqueDays[i]).getTime();
-    if ((prev - curr) / 86_400_000 === 1) streak++;
+    // GW-3: Math.round 容差——当前 UTC 解析精确 86400000ms，但防御未来
+    // 日期格式变更（本地时区偏移）引入的 DST 23/25 小时抖动
+    const dayDiff = Math.round((prev - curr) / 86_400_000);
+    if (dayDiff === 1) streak++;
     else break;
   }
   return streak;

client/src/features/retention/store/useEcosystemStore.ts

@@ -46,7 +46,10 @@ export const useEcosystemStore = create<EcosystemState>((set, get) => ({
         const sorted = [...corals].sort(
           (a, b) => new Date(b.plantedAt).getTime() - new Date(a.plantedAt).getTime(),
         );
-        const lastDate = new Date(sorted[0].plantedAt).toISOString().split('T')[0];
+        // GW-3: 本地日期口径（与 FRONT2-M3 一致）——原实现 toISOString 取
+        // UTC 日期，UTC+8 用户凌晨种植后白化判定偏差一天
+        const lastPlant = new Date(sorted[0].plantedAt);
+        const lastDate = `${lastPlant.getFullYear()}-${String(lastPlant.getMonth() + 1).padStart(2, '0')}-${String(lastPlant.getDate()).padStart(2, '0')}`;
         const toBleach = checkBleaching(corals, lastDate, new Date());
         if (toBleach.length > 0) {
           for (const id of toBleach) {
@@ -117,6 +120,9 @@ export const useEcosystemStore = create<EcosystemState>((set, get) => ({
         await db.coralEcosystem.update(c.id, { health: 'healthy' });
       } catch { /* ignore */ }
     }
-    set({ corals: restored });
+    // GW-3: 与 plantCoral 同口径——写库完成后重读再 set，避免旧快照
+    // 覆盖并发 plantCoral 的最新状态
+    const latest = await db.coralEcosystem.toArray();
+    set({ corals: latest });
   },
 }));

client/src/lib/crypto/CryptoManager.ts

@@ -171,12 +171,11 @@ export class CryptoManager {
     if (api?.safeStorageEncrypt && api?.safeStorageDecrypt) {
       const storedEnc = localStorage.getItem(encryptedKey);
       if (storedEnc) {
-        try {
-          return await api.safeStorageDecrypt(storedEnc);
-        } catch {
-          // OS 密钥轮换/系统重装导致解密失败：回退重建新密钥材料
-          console.warn('[CryptoManager] safeStorage 解密失败，重建密钥材料');
-        }
+        // GW-3: 解密失败绝不自动重建密钥——旧密钥材料丢失会使此前加密的
+        // 全部敏感字段永久不可解密（原实现静默重建并覆写 _enc 键，数据
+        // 不可逆损坏）。异常向上传播到 init 的 catch → initFailed + 抛错，
+        // 由 UI 提示"加密数据不可用"并保留旧密文等待用户恢复
+        return await api.safeStorageDecrypt(storedEnc);
       }
       const deviceKey = this.generateDeviceKey();
       try {

client/src/lib/storage/operationLog.ts

@@ -101,7 +101,10 @@ export async function markLogsSynced(ids: string[]): Promise<void> {
 export async function markEntityLogsSynced(entityType: string, entityId: string): Promise<void> {
   const logs = await db.operationLog
     .where('entityType').equals(entityType)
-    .filter(l => l.entityId === entityId && l.synced === 0)
+    // GW-3: 用 `!== 1` 而非 `=== 0`——旧数据 synced 可能为 boolean false
+    //（历史版本写入）或 undefined，严格相等会漏标，形成永久孤数据；
+    // 且这些旧日志若未来迁移为 0 会重新参与 push 触发冲突循环
+    .filter(l => l.entityId === entityId && l.synced !== 1)
     .toArray();
   if (logs.length === 0) return;
   await db.operationLog.bulkUpdate(logs.map(l => ({

client/src/lib/storage/writeWithLog.ts

@@ -173,7 +173,14 @@ async function applyCRDTChange(
     // applyLocalChange 已前滚内存 doc，若 enqueue/persistDoc 失败，
     // 内存与队列/快照基线漂移，下次变更会生成非法 changeset
     //（MissingDependencyError），该表 CRDT 路径从此永久失效
-    await crdtEngine.resetTable(tableName);
+    // GW-3: resetTable 本身可能失败（IndexedDB 异常），嵌套保护避免
+    //"降级路径"反而阻塞主写入（resetTable 失败时内存状态未重建，
+    // 下次 init 会从快照重建，风险低于阻塞业务写入）
+    try {
+      await crdtEngine.resetTable(tableName);
+    } catch (resetErr) {
+      console.warn('[writeWithLog] CRDT resetTable also failed (non-blocking):', resetErr);
+    }
     console.warn('[writeWithLog] CRDT change failed, table reset (non-blocking):', err);
   }
 }

client/src/lib/sync/OfflineQueue.ts

@@ -42,11 +42,13 @@ export class OfflineQueue {
     const deviceId = getDeviceId();
 
     // 在 Dexie 事务内完成"读 max version + 1 + 写入"，避免版本号竞态
-    // SYNC2-L4: 取最大值必须按 version（单调自增主键）而非 createdAt——
-    // Date 毫秒精度下同一毫秒的并发写入会取到错误基线，产生重复版本号
+    // SYNC2-L4: 取最大值按 version（单调自增）而非 createdAt——Date 毫秒
+    // 精度下同一毫秒的并发写入会取到错误基线，产生重复版本号
+    // GW-3: version 非索引字段，orderBy 会抛 SchemaError（Dexie 硬性要求）——
+    // 改用 sortBy 内存排序（队列数据量小，性能可接受）
     await db.transaction('rw', db.offlineQueue, async () => {
-      const items = await db.offlineQueue.orderBy('version').reverse().limit(1).toArray();
-      const version = items.length > 0 ? (items[0].version || 0) + 1 : 1;
+      const items = await db.offlineQueue.sortBy('version');
+      const version = items.length > 0 ? (items[items.length - 1].version || 0) + 1 : 1;
 
       await db.offlineQueue.add({
         id,
@@ -68,7 +70,9 @@ export class OfflineQueue {
    * 获取所有待处理队列项
    */
   async getPendingItems(): Promise<OfflineQueueItem[]> {
-    return db.offlineQueue.orderBy('version').toArray();
+    // GW-3: version 非索引字段，orderBy 抛 SchemaError（Dexie 硬性要求）——
+    // 原实现从未真正工作；改 sortBy 内存排序
+    return db.offlineQueue.sortBy('version');
   }
 
   /**
@@ -122,7 +126,8 @@ export class OfflineQueue {
    */
   async getReadyItems(maxRetries: number = 5): Promise<OfflineQueueItem[]> {
     const now = Date.now();
-    const items = await db.offlineQueue.orderBy('version').toArray();
+    // GW-3: 同 getPendingItems——orderBy('version') 抛 SchemaError，改内存排序
+    const items = await db.offlineQueue.sortBy('version');
     return items.filter(
       item =>
         item.retryCount < maxRetries &&