Skip to content

CreateMenuItem memory leak #85

Description

@RazoomGD

Tinker Issue

  • I verify that this bug report isn't a crash or a touch related issues.

Tinker version

1.0.17

Geode version

5.7.1

Bug description

Tinker leaks one CreateMenuItem on every editor session. Tested with the code below:

#include <Geode/Geode.hpp>

using namespace geode::prelude;

#include <Geode/modify/CreateMenuItem.hpp>

static int aaaaa = 0;

class $modify(MyCreateMenuItem, CreateMenuItem) {
	struct Fields {
		Fields() {
			log::debug("CMI+ {}", ++aaaaa);
		}
		~Fields() {
			log::debug("CMI- {}", --aaaaa);
		}
	};

	static CreateMenuItem* create(CCNode* p0, CCNode* p1, CCObject* p2, SEL_MenuHandler p3) {
		CreateMenuItem* ret = CreateMenuItem::create(p0, p1, p2, p3);
		static_cast<MyCreateMenuItem*>(ret)->m_fields.self();
		return ret;
	}
};

Extra Media

No response

Platform

Windows

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions