[PWGCF] FemtoUniverse: Fix hardcoded pion mass, add filling only primary MC pairs#16593
Open
alicja-pp wants to merge 3 commits into
Open
[PWGCF] FemtoUniverse: Fix hardcoded pion mass, add filling only primary MC pairs#16593alicja-pp wants to merge 3 commits into
alicja-pp wants to merge 3 commits into
Conversation
alicja-pp
requested review from
alibuild,
lauraser,
lgraczykCern,
prchakra,
shouqiye,
victor-gonzalez and
wrzesaCERN
as code owners
github-actions
Bot
changed the title
|
O2 linter results: ❌ 7 errors, |
vkucera
requested changes
Jun 9, 2026
Comment on lines
-250
to
251
| mMassOne = o2::constants::physics::MassPiPlus; // FIXME: Get from the PDG service of the common header | ||
| mMassTwo = o2::constants::physics::MassPiPlus; // FIXME: Get from the PDG service of the common header | ||
| mMassOne = TDatabasePDG::Instance()->GetParticle(pdg1)->Mass(); | ||
| mMassTwo = TDatabasePDG::Instance()->GetParticle(pdg2)->Mass(); | ||
| } |
Collaborator
There was a problem hiding this comment.
I already commented in the other PR that this is not allowed. Why are you adding it yet to another place?
Contributor
Author
There was a problem hiding this comment.
I tried to change this but the solution gave a segmentation fault in this case. I need this function fix quicker. I plan to debug this O2 linter error when possible.
Collaborator
There was a problem hiding this comment.
- You need to pass a pointer to the PDG service plugin from the task.
- When will you fix it?
- At least add a
FIXMEcomment.
Contributor
Author
There was a problem hiding this comment.
I have managed to find other way around it. Is it ok?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PWGCF/FemtoUniverse/Core/FemtoUniverseFemtoContainer.hadd option to fill only primary MC pairs in MC histograms
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.hfix harcoded setPionPairMass() into setPDGCodes that sets masses according to configurable
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackTrackMultKtExtended.cxxadd configurable confOnlyPrimaryMCPair
[pdg/database] O2 linter error will be fixed in the future, as it is not needed right now, and there were issues with fix