[PWGCF] Fix code check errors in femto framework (#18518)

Author: ariedel-cern

PWGCF/Femto/Core/baseSelection.h

@@ -292,7 +292,7 @@ class BaseSelection
   /// \brief Evaluate a single observable against its configured selections.
   /// \param observableIndex Index of the observable.
   /// \param values Vector of values of the observable.
-  void evaluateObservable(int observableIndex, std::vector<T> values)
+  void evaluateObservable(int observableIndex, std::vector<T> const& values)
   {
     // if there are no selections configured, bail out
     if (mSelectionContainers.at(observableIndex).isEmpty()) {

PWGCF/Femto/Core/collisionBuilder.h

@@ -334,7 +334,7 @@ class CollisionSelection : public baseselection::BaseSelection<float, o2::analys
   }
 
   template <typename T>
-  void setSphericity(T tracks)
+  void setSphericity(T const& tracks)
   {
     mSphericity = computeSphericity(tracks);
   }

PWGCF/Femto/Core/mcBuilder.h

@@ -556,7 +556,7 @@ class McBuilder
     int64_t mcMotherRow = -1;
     if (mProduceMcMothers && mcParticle.has_mothers()) {
       auto mothers = mcParticle.template mothers_as<T2>();
-      auto motherParticle = mothers.front();
+      auto const& motherParticle = mothers.front();
       auto mcMotherIndex = motherParticle.globalIndex();
 
       auto itM = mMcMotherMap.find(mcMotherIndex);

PWGCF/Femto/Core/trackBuilder.h

@@ -27,8 +27,12 @@
 #include <Framework/AnalysisHelpers.h>
 #include <Framework/Configurable.h>
 #include <Framework/HistogramRegistry.h>
+#include <Framework/HistogramSpec.h>
 #include <Framework/Logger.h>
 
+#include <TH1.h>
+
+#include <array>
 #include <cmath>
 #include <cstdint>
 #include <string>
@@ -684,10 +688,17 @@ class TrackBuilder
       auto hSlotAssignment = registry->get<TH1>(HIST("hPuritySlotAssignment"));
       for (int i = 0; i < PuritySpeciesLast; i++) {
         std::string bitPosition = mPuritySlot[i] >= 0 ? std::to_string(mPuritySlot[i]) : "X";
-        std::string value = mPuritySlot[i] >= 0 ? ("Slot " + std::to_string(mPuritySlot[i])) : "Not configured";
-        std::string label = std::string("SelectionName___") + PuritySpeciesName[i] +
-                            ":::MinimalCut___0:::OptionalCut___0:::BitPosition___" + bitPosition +
-                            ":::Value___" + value;
+        std::string value = "Not configured";
+        if (mPuritySlot[i] >= 0) {
+          value = "Slot ";
+          value += std::to_string(mPuritySlot[i]);
+        }
+        std::string label = "SelectionName___";
+        label += PuritySpeciesName[i];
+        label += ":::MinimalCut___0:::OptionalCut___0:::BitPosition___";
+        label += bitPosition;
+        label += ":::Value___";
+        label += value;
         hSlotAssignment->GetXaxis()->SetBinLabel(i + 1, label.c_str());
         hSlotAssignment->Fill(i, 1);
       }

PWGCF/Femto/Core/trackHistManager.h

@@ -29,6 +29,7 @@
 #include <TH1.h>
 
 #include <array>
+#include <cmath>
 #include <cstddef>
 #include <map>
 #include <string>