Skip to content

Commit 910efe6

Browse files
Remove stale disabled-test comments and re-enable already-fixed tests (#291)
Three TODO/disabled-test comments described bugs that were already fixed (2026-07-05, see jit-globals-not-gc-roots and coro-dynamic-alloca-print-crash history) but never got cleaned up: - test-compile-Raytrace / test-jit-Raytrace: "TODO: find out why it is crashing" - fixed via GC_add_roots registration for JIT'd globals. - test-compile-00-for-await-yield: was commented out entirely ("TODO: in opt mode, error") - fixed via heap-allocating string-concat scratch buffers inside presplit coroutines instead of a dynamic stack alloca. Re-enabled. - test-jit-00-for-await-yield: had a stale comment describing the same now-fixed coroutine crash above an already-enabled, already-passing test. 817/817 tests green (816 + newly re-enabled test-compile-00-for-await-yield). Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 parent bc91ff4 commit 910efe6

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

tslang/test/tester/CMakeLists.txt

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -327,8 +327,7 @@ add_test(NAME test-compile-01-optional COMMAND test-runner "${PROJECT_SOURCE_DIR
327327
add_test(NAME test-compile-00-async-await COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/00async_await.ts")
328328
add_test(NAME test-compile-00-for-await COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/00for_await.ts")
329329

330-
# TODO: in opt mode, error
331-
#add_test(NAME test-compile-00-for-await-yield COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/00for_await_yield.ts")
330+
add_test(NAME test-compile-00-for-await-yield COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/00for_await_yield.ts")
332331
add_test(NAME test-compile-00-types COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/00types.ts")
333332
add_test(NAME test-compile-00-try-catch COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/00try_catch.ts")
334333
add_test(NAME test-compile-01-try-catch COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/01try_catch.ts")
@@ -435,7 +434,6 @@ add_test(NAME test-compile-244-arraysome COMMAND test-runner "${PROJECT_SOURCE_D
435434
add_test(NAME test-compile-Grammar_and_types COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/Grammar_and_types.ts")
436435
add_test(NAME test-compile-StackTest COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/00stack_test.ts")
437436
if (WIN32)
438-
# TODO: find out why it is crashing
439437
add_test(NAME test-compile-Raytrace COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/raytrace.ts")
440438
endif()
441439
add_test(NAME test-compile-Path COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/path.ts")
@@ -691,8 +689,6 @@ add_test(NAME test-jit-00-optional COMMAND test-runner -jit "${PROJECT_SOURCE_DI
691689
add_test(NAME test-jit-01-optional COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/01optional.ts")
692690
add_test(NAME test-jit-00-async-await COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/00async_await.ts")
693691
add_test(NAME test-jit-00-for-await COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/00for_await.ts")
694-
# TODO: async generator / for-await-of hangs at runtime under JIT
695-
# error: EXEC : LLVM error : Coroutines cannot handle non static allocas yet
696692
add_test(NAME test-jit-00-for-await-yield COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/00for_await_yield.ts")
697693
add_test(NAME test-jit-00-try-catch COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/00try_catch.ts")
698694
add_test(NAME test-jit-01-try-catch COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/01try_catch.ts")
@@ -805,7 +801,6 @@ add_test(NAME test-jit-243-arrayevery COMMAND test-runner -jit "${PROJECT_SOURC
805801
add_test(NAME test-jit-244-arraysome COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/244arraysome.ts")
806802
add_test(NAME test-jit-Grammar_and_types COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/Grammar_and_types.ts")
807803
add_test(NAME test-jit-StackTest COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/00stack_test.ts")
808-
# TODO: find out why it is crashing
809804
add_test(NAME test-jit-Raytrace COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/raytrace.ts")
810805
add_test(NAME test-jit-Path COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/path.ts")
811806
add_test(NAME test-jit-Print-Bug-01 COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/01print-bug.ts")

0 commit comments

Comments
 (0)